Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
3762c294
Commit
3762c294
authored
Mar 04, 2016
by
Hugh McMaster
Committed by
Alexandre Julliard
Mar 04, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
reg: Fail if REG_DWORD_BIG_ENDIAN is passed with no data argument.
Signed-off-by:
Hugh McMaster
<
hugh.mcmaster@outlook.com
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
9bfddcf7
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
5 deletions
+3
-5
reg.c
programs/reg/reg.c
+1
-1
reg.c
programs/reg/tests/reg.c
+2
-4
No files found.
programs/reg/reg.c
View file @
3762c294
...
@@ -404,7 +404,7 @@ static int reg_add(WCHAR *key_name, WCHAR *value_name, BOOL value_empty,
...
@@ -404,7 +404,7 @@ static int reg_add(WCHAR *key_name, WCHAR *value_name, BOOL value_empty,
output_message
(
STRING_UNSUPPORTED_TYPE
,
type
);
output_message
(
STRING_UNSUPPORTED_TYPE
,
type
);
return
1
;
return
1
;
}
}
if
(
reg_type
==
REG_DWORD
&&
!
data
)
if
(
(
reg_type
==
REG_DWORD
||
reg_type
==
REG_DWORD_BIG_ENDIAN
)
&&
!
data
)
{
{
RegCloseKey
(
subkey
);
RegCloseKey
(
subkey
);
output_message
(
STRING_INVALID_CMDLINE
);
output_message
(
STRING_INVALID_CMDLINE
);
...
...
programs/reg/tests/reg.c
View file @
3762c294
...
@@ -351,12 +351,10 @@ static void test_add(void)
...
@@ -351,12 +351,10 @@ static void test_add(void)
ok
(
r
==
REG_EXIT_FAILURE
,
"got exit code %u, expected 1
\n
"
,
r
);
ok
(
r
==
REG_EXIT_FAILURE
,
"got exit code %u, expected 1
\n
"
,
r
);
run_reg_exe
(
"reg add HKCU
\\
"
KEY_BASE
" /v DWORD_BE3 /t REG_DWORD_BIG_ENDIAN /f"
,
&
r
);
run_reg_exe
(
"reg add HKCU
\\
"
KEY_BASE
" /v DWORD_BE3 /t REG_DWORD_BIG_ENDIAN /f"
,
&
r
);
todo_wine
ok
(
r
==
REG_EXIT_FAILURE
||
broken
(
r
==
REG_EXIT_SUCCESS
/* WinXP */
),
ok
(
r
==
REG_EXIT_FAILURE
||
broken
(
r
==
REG_EXIT_SUCCESS
/* WinXP */
),
"got exit code %u
\n
"
,
r
);
"got exit code %u
\n
"
,
r
);
run_reg_exe
(
"reg add HKCU
\\
"
KEY_BASE
" /ve /t REG_DWORD_BIG_ENDIAN /f"
,
&
r
);
run_reg_exe
(
"reg add HKCU
\\
"
KEY_BASE
" /ve /t REG_DWORD_BIG_ENDIAN /f"
,
&
r
);
todo_wine
ok
(
r
==
REG_EXIT_FAILURE
||
broken
(
r
==
REG_EXIT_SUCCESS
/* WinXP */
),
ok
(
r
==
REG_EXIT_FAILURE
||
broken
(
r
==
REG_EXIT_SUCCESS
/* WinXP */
),
"got exit code %u
\n
"
,
r
);
"got exit code %u
\n
"
,
r
);
/* REG_MULTI_SZ */
/* REG_MULTI_SZ */
run_reg_exe
(
"reg add HKCU
\\
"
KEY_BASE
" /v multi0 /t REG_MULTI_SZ /d
\"
three
\\
0little
\\
0strings
\"
/f"
,
&
r
);
run_reg_exe
(
"reg add HKCU
\\
"
KEY_BASE
" /v multi0 /t REG_MULTI_SZ /d
\"
three
\\
0little
\\
0strings
\"
/f"
,
&
r
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment