msi: Avoid leaking stream on DB update.

MSI_RecordGetIStream adds a reference to the stream. This reference should be negated as we are done setting the stream. Signed-off-by: David Kahurani <k.kahurani@gmail.com>

msi: Avoid leaking stream on DB update.
386dbe10 · David Kahurani · Alexandre Julliard · 9a614fef · 386dbe10
Commit 386dbe10 authored Jan 18, 2024 by David Kahurani Committed by Alexandre Julliard Feb 20, 2024
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

select.c dlls/msi/select.c +3 -0

No files found.
--- a/dlls/msi/select.c
+++ b/dlls/msi/select.c
@@ -20,6 +20,8 @@

 #include <stdarg.h>

+#define COBJMACROS
+
 #include "windef.h"
 #include "winbase.h"
 #include "winerror.h"
@@ -269,6 +271,7 @@ UINT msi_select_update(MSIVIEW *view, MSIRECORD *rec, UINT row)
            if (MSI_RecordGetIStream(rec, i + 1, &stream))
                return ERROR_FUNCTION_FAILED;
            r = sv->table->ops->set_stream(sv->table, row, col, stream);
+            IStream_Release(stream);
        }
        else if (type & MSITYPE_STRING)
        {