- now reporting message on bogus line number in 'bp <num>' commands

(useful when user thinks <num> is a linear address) - fixed bogus return value in DEBUG_AddBreakpoint

- now reporting message on bogus line number in 'bp <num>' commands
39628f49 · Eric Pouech · Alexandre Julliard · da49807e · 39628f49
Commit 39628f49 authored Jan 28, 2004 by Eric Pouech Committed by Alexandre Julliard Jan 28, 2004
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 3 deletions

break.c programs/winedbg/break.c +8 -3

No files found.
--- a/programs/winedbg/break.c
+++ b/programs/winedbg/break.c
@@ -368,7 +368,7 @@ BOOL DEBUG_AddBreakpoint( const DBG_VALUE *value, BOOL (*func)(void), BOOL verbo
 			TRUE );
    DEBUG_Printf("\n");

-    return FALSE;
+    return TRUE;
 }

 /***********************************************************************
@@ -472,12 +472,17 @@ void	DEBUG_AddBreakpointFromLineno(int lineno)
            DEBUG_Printf("Unable to add breakpoint\n");
            return;
        }
-        DEBUG_GetLineNumberAddr(nh, lineno, &value.addr, TRUE);
+        if (!DEBUG_GetLineNumberAddr(nh, lineno, &value.addr, TRUE))
+        {
+            DEBUG_Printf("Unknown line number\n"
+                         "(either out of file, or no code at given line number)\n");
+            return;
+        }
    }

    value.type = NULL;
    value.cookie = DV_TARGET;
-    DEBUG_AddBreakpoint( &value,NULL, TRUE );
+    DEBUG_AddBreakpoint( &value, NULL, TRUE );
 }

 /***********************************************************************