jscript: Don't use atomic compare exchange when setting the script ctx.

It already bails out early if the thread_data was already populated, so only one thread can reach here at one time. Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>

jscript: Don't use atomic compare exchange when setting the script ctx.
39c7950a · Gabriel Ivăncescu · Alexandre Julliard · f55db652 · 39c7950a
Commit 39c7950a authored Dec 12, 2023 by Gabriel Ivăncescu Committed by Alexandre Julliard Jan 22, 2024
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 5 deletions

jscript.c dlls/jscript/jscript.c +1 -5

No files found.
--- a/dlls/jscript/jscript.c
+++ b/dlls/jscript/jscript.c
@@ -776,11 +776,7 @@ static HRESULT WINAPI JScript_SetScriptSite(IActiveScript *iface,

        ctx->last_match = jsstr_empty();

-        ctx = InterlockedCompareExchangePointer((void**)&This->ctx, ctx, NULL);
-        if(ctx) {
-            script_release(ctx);
-            return E_UNEXPECTED;
-        }
+        This->ctx = ctx;
    }

    /* Retrieve new dispatches for persistent named items */