Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
3b3a65ad
Commit
3b3a65ad
authored
Nov 28, 2023
by
Daniel Lehman
Committed by
Alexandre Julliard
Dec 04, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msxml3: Handle default namespace in get_baseName.
parent
bed12d84
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
3 deletions
+7
-3
node.c
dlls/msxml3/node.c
+5
-1
domdoc.c
dlls/msxml3/tests/domdoc.c
+1
-1
domdoc.c
dlls/msxml4/tests/domdoc.c
+1
-1
No files found.
dlls/msxml3/node.c
View file @
3b3a65ad
...
...
@@ -1609,7 +1609,11 @@ HRESULT node_get_base_name(xmlnode *This, BSTR *name)
{
if
(
!
name
)
return
E_INVALIDARG
;
*
name
=
bstr_from_xmlChar
(
This
->
node
->
name
);
if
(
xmldoc_version
(
This
->
node
->
doc
)
!=
MSXML6
&&
xmlStrEqual
(
This
->
node
->
name
,
BAD_CAST
"xmlns"
))
*
name
=
SysAllocString
(
L""
);
else
*
name
=
bstr_from_xmlChar
(
This
->
node
->
name
);
if
(
!*
name
)
return
E_OUTOFMEMORY
;
TRACE
(
"returning %s
\n
"
,
debugstr_w
(
*
name
));
...
...
dlls/msxml3/tests/domdoc.c
View file @
3b3a65ad
...
...
@@ -13778,6 +13778,7 @@ static void test_namespaces_as_attributes(void)
str
=
NULL
;
hr
=
IXMLDOMNode_get_nodeName
(
item
,
&
str
);
ok
(
hr
==
S_OK
,
"Unexpected hr %#lx.
\n
"
,
hr
);
todo_wine_if
(
test
->
todo
)
ok
(
!
lstrcmpW
(
str
,
_bstr_
(
test
->
names
[
i
])),
"got %s
\n
"
,
wine_dbgstr_w
(
str
));
SysFreeString
(
str
);
...
...
@@ -13797,7 +13798,6 @@ static void test_namespaces_as_attributes(void)
str
=
NULL
;
hr
=
IXMLDOMNode_get_baseName
(
item
,
&
str
);
ok
(
hr
==
S_OK
,
"Unexpected hr %#lx.
\n
"
,
hr
);
todo_wine_if
(
test
->
todo
)
ok
(
!
lstrcmpW
(
str
,
_bstr_
(
test
->
basenames
[
i
])),
"got %s
\n
"
,
wine_dbgstr_w
(
str
));
SysFreeString
(
str
);
...
...
dlls/msxml4/tests/domdoc.c
View file @
3b3a65ad
...
...
@@ -261,6 +261,7 @@ static void test_namespaces_as_attributes(void)
str
=
NULL
;
hr
=
IXMLDOMNode_get_nodeName
(
item
,
&
str
);
ok
(
hr
==
S_OK
,
"Unexpected hr %#lx.
\n
"
,
hr
);
todo_wine_if
(
test
->
todo
)
ok
(
!
lstrcmpW
(
str
,
test
->
names
[
i
]),
"got %s
\n
"
,
wine_dbgstr_w
(
str
));
SysFreeString
(
str
);
...
...
@@ -283,7 +284,6 @@ static void test_namespaces_as_attributes(void)
hr
=
IXMLDOMNode_get_baseName
(
item
,
&
str
);
/* MSXML4 can report different results with different service packs */
ok
(
hr
==
S_OK
,
"Unexpected hr %#lx.
\n
"
,
hr
);
todo_wine_if
(
test
->
todo
)
ok
(
!
lstrcmpW
(
str
,
test
->
basenames
[
i
])
||
broken
(
!
lstrcmpW
(
str
,
L"xmlns"
)),
"got %s
\n
"
,
wine_dbgstr_w
(
str
));
SysFreeString
(
str
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment