ole32: Fix a leak of the IBindCtx object in FileMonikerImpl_IsEqual.

3bd22200 · Rob Shearman · Alexandre Julliard · 2249565e · 3bd22200
Commit 3bd22200 authored Nov 10, 2007 by Rob Shearman Committed by Alexandre Julliard Nov 12, 2007
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 3 deletions

filemoniker.c dlls/ole32/filemoniker.c +5 -3

No files found.
--- a/dlls/ole32/filemoniker.c
+++ b/dlls/ole32/filemoniker.c
@@ -793,13 +793,15 @@ FileMonikerImpl_IsEqual(IMoniker* iface,IMoniker* pmkOtherMoniker)
    res = CreateBindCtx(0,&bind);
    if (FAILED(res)) return res;

+    res = S_FALSE;
    if (SUCCEEDED(IMoniker_GetDisplayName(pmkOtherMoniker,bind,NULL,&filePath))) {
-	int result = lstrcmpiW(filePath, This->filePathName);
+	if (!lstrcmpiW(filePath, This->filePathName))
+            res = S_OK;
 	CoTaskMemFree(filePath);
-        if ( result == 0 ) return S_OK;
    }
-    return S_FALSE;

+    IBindCtx_Release(bind);
+    return res;
 }

 /******************************************************************************