msi: Don't wait on closed handles in ACTION_FinishCustomActions.

The handle will be closed by free_custom_action_data, so duplicate the handle before calling it.

msi: Don't wait on closed handles in ACTION_FinishCustomActions.
3fbe9db4 · Rob Shearman · Alexandre Julliard · 20171ac2 · 3fbe9db4
Commit 3fbe9db4 authored Apr 03, 2007 by Rob Shearman Committed by Alexandre Julliard Apr 04, 2007
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

custom.c dlls/msi/custom.c +5 -1

No files found.
--- a/dlls/msi/custom.c
+++ b/dlls/msi/custom.c
@@ -887,7 +887,8 @@ void ACTION_FinishCustomActions(MSIPACKAGE* package)
    {
        if (info->package == package )
        {
-            wait_handles[handle_count++] = info->handle;
+            if (DuplicateHandle(GetCurrentProcess(), info->handle, GetCurrentProcess(), &wait_handles[handle_count], SYNCHRONIZE, FALSE, 0))
+                handle_count++;
            free_custom_action_data( info );
        }
    }
@@ -895,7 +896,10 @@ void ACTION_FinishCustomActions(MSIPACKAGE* package)
    LeaveCriticalSection( &msi_custom_action_cs );

    for (i = 0; i < handle_count; i++)
+    {
        msi_dialog_check_messages( wait_handles[i] );
+        CloseHandle( wait_handles[i] );
+    }

    HeapFree( GetProcessHeap(), 0, wait_handles );
 }