Commit 40f3a9fa authored by Andrew Talbot's avatar Andrew Talbot Committed by Alexandre Julliard

msi: Avoid signed-unsigned integer comparisons.

parent 51a79287
...@@ -154,7 +154,6 @@ void msi_free_action_script( MSIPACKAGE *package, UINT script ) ...@@ -154,7 +154,6 @@ void msi_free_action_script( MSIPACKAGE *package, UINT script )
static void free_package_structures( MSIPACKAGE *package ) static void free_package_structures( MSIPACKAGE *package )
{ {
INT i;
struct list *item, *cursor; struct list *item, *cursor;
LIST_FOR_EACH_SAFE( item, cursor, &package->features ) LIST_FOR_EACH_SAFE( item, cursor, &package->features )
...@@ -283,11 +282,14 @@ static void free_package_structures( MSIPACKAGE *package ) ...@@ -283,11 +282,14 @@ static void free_package_structures( MSIPACKAGE *package )
if (package->script) if (package->script)
{ {
INT i;
UINT j;
for (i = 0; i < SCRIPT_MAX; i++) for (i = 0; i < SCRIPT_MAX; i++)
msi_free_action_script( package, i ); msi_free_action_script( package, i );
for (i = 0; i < package->script->UniqueActionsCount; i++) for (j = 0; j < package->script->UniqueActionsCount; j++)
msi_free( package->script->UniqueActions[i] ); msi_free( package->script->UniqueActions[j] );
msi_free( package->script->UniqueActions ); msi_free( package->script->UniqueActions );
msi_free( package->script ); msi_free( package->script );
......
...@@ -922,7 +922,7 @@ static UINT parse_prop( LPCWSTR prop, LPCWSTR value, UINT *pid, INT *int_value, ...@@ -922,7 +922,7 @@ static UINT parse_prop( LPCWSTR prop, LPCWSTR value, UINT *pid, INT *int_value,
UINT msi_add_suminfo( MSIDATABASE *db, LPWSTR **records, int num_records, int num_columns ) UINT msi_add_suminfo( MSIDATABASE *db, LPWSTR **records, int num_records, int num_columns )
{ {
UINT r = ERROR_FUNCTION_FAILED; UINT r = ERROR_FUNCTION_FAILED;
DWORD i, j; int i, j;
MSISUMMARYINFO *si; MSISUMMARYINFO *si;
si = MSI_GetSummaryInformationW( db->storage, num_records * (num_columns / 2) ); si = MSI_GetSummaryInformationW( db->storage, num_records * (num_columns / 2) );
......
...@@ -770,7 +770,7 @@ static UINT WHERE_execute( struct tagMSIVIEW *view, MSIRECORD *record ) ...@@ -770,7 +770,7 @@ static UINT WHERE_execute( struct tagMSIVIEW *view, MSIRECORD *record )
JOINTABLE *table = wv->tables; JOINTABLE *table = wv->tables;
UINT *rows; UINT *rows;
JOINTABLE **ordered_tables; JOINTABLE **ordered_tables;
int i = 0; UINT i = 0;
TRACE("%p %p\n", wv, record); TRACE("%p %p\n", wv, record);
...@@ -1052,7 +1052,7 @@ static UINT WHERE_sort(struct tagMSIVIEW *view, column_info *columns) ...@@ -1052,7 +1052,7 @@ static UINT WHERE_sort(struct tagMSIVIEW *view, column_info *columns)
column_info *column = columns; column_info *column = columns;
MSIORDERINFO *orderinfo; MSIORDERINFO *orderinfo;
UINT r, count = 0; UINT r, count = 0;
int i; UINT i;
TRACE("%p %p\n", view, columns); TRACE("%p %p\n", view, columns);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment