Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
4376ccf3
Commit
4376ccf3
authored
Nov 30, 2009
by
Michael Stefaniuc
Committed by
Alexandre Julliard
Dec 01, 2009
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
comctl32: Use FAILED instead of !SUCCEEDED.
parent
35b2ca94
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
6 deletions
+6
-6
imagelist.c
dlls/comctl32/imagelist.c
+4
-4
imagelist.c
dlls/comctl32/tests/imagelist.c
+2
-2
No files found.
dlls/comctl32/imagelist.c
View file @
4376ccf3
...
...
@@ -598,7 +598,7 @@ ImageList_Create (INT cx, INT cy, UINT flags,
TRACE
(
"(%d %d 0x%x %d %d)
\n
"
,
cx
,
cy
,
flags
,
cInitial
,
cGrow
);
/* Create the IImageList interface for the image list */
if
(
!
SUCCEEDED
(
ImageListImpl_CreateInstance
(
NULL
,
&
IID_IImageList
,
(
void
**
)
&
himl
)))
if
(
FAILED
(
ImageListImpl_CreateInstance
(
NULL
,
&
IID_IImageList
,
(
void
**
)
&
himl
)))
return
NULL
;
cGrow
=
(
cGrow
<
4
)
?
4
:
(
cGrow
+
3
)
&
~
3
;
...
...
@@ -3101,7 +3101,7 @@ static HRESULT WINAPI ImageListImpl_Copy(IImageList *iface, int iDst,
return
E_FAIL
;
/* TODO: Add test for IID_ImageList2 too */
if
(
!
SUCCEED
ED
(
IImageList_QueryInterface
(
punkSrc
,
&
IID_IImageList
,
if
(
FAIL
ED
(
IImageList_QueryInterface
(
punkSrc
,
&
IID_IImageList
,
(
void
**
)
&
src
)))
return
E_FAIL
;
...
...
@@ -3126,7 +3126,7 @@ static HRESULT WINAPI ImageListImpl_Merge(IImageList *iface, int i1,
return
E_FAIL
;
/* TODO: Add test for IID_ImageList2 too */
if
(
!
SUCCEED
ED
(
IImageList_QueryInterface
(
punk2
,
&
IID_IImageList
,
if
(
FAIL
ED
(
IImageList_QueryInterface
(
punk2
,
&
IID_IImageList
,
(
void
**
)
&
iml2
)))
return
E_FAIL
;
...
...
@@ -3260,7 +3260,7 @@ static HRESULT WINAPI ImageListImpl_SetDragCursorImage(IImageList *iface,
return
E_FAIL
;
/* TODO: Add test for IID_ImageList2 too */
if
(
!
SUCCEED
ED
(
IImageList_QueryInterface
(
punk
,
&
IID_IImageList
,
if
(
FAIL
ED
(
IImageList_QueryInterface
(
punk
,
&
IID_IImageList
,
(
void
**
)
&
iml2
)))
return
E_FAIL
;
...
...
dlls/comctl32/tests/imagelist.c
View file @
4376ccf3
...
...
@@ -1424,7 +1424,7 @@ static void DoTest1_v6(void)
ok
(
SUCCEEDED
(
IImageList_ReplaceIcon
(
imgl
,
-
1
,
hicon3
,
&
ret
))
&&
(
ret
==
2
),
"failed to add icon3
\n
"
);
/* remove an index out of range */
ok
(
!
SUCCEEDED
(
IImageList_Remove
(
imgl
,
4711
)),
"removed nonexistent icon
\n
"
);
ok
(
FAILED
(
IImageList_Remove
(
imgl
,
4711
)),
"removed nonexistent icon
\n
"
);
/* remove three */
ok
(
SUCCEEDED
(
IImageList_Remove
(
imgl
,
0
)),
"can't remove 0
\n
"
);
...
...
@@ -1432,7 +1432,7 @@ static void DoTest1_v6(void)
ok
(
SUCCEEDED
(
IImageList_Remove
(
imgl
,
0
)),
"can't remove 0
\n
"
);
/* remove one extra */
ok
(
!
SUCCEEDED
(
IImageList_Remove
(
imgl
,
0
)),
"removed nonexistent icon
\n
"
);
ok
(
FAILED
(
IImageList_Remove
(
imgl
,
0
)),
"removed nonexistent icon
\n
"
);
/* check SetImageCount/GetImageCount */
ok
(
SUCCEEDED
(
IImageList_SetImageCount
(
imgl
,
3
)),
"couldn't increase image count
\n
"
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment