ole32: Fix potential NULL dereference of qiresults in ClientIdentity_QueryMultipleInterfaces.

This could happen if proxy_manager_get_remunknown returns S_FALSE, so fix the check of the return code to match that below.

ole32: Fix potential NULL dereference of qiresults in ClientIdentity_QueryMultipleInterfaces.
461ce6e4 · Rob Shearman · Alexandre Julliard · bfa6ddae · 461ce6e4
Commit 461ce6e4 authored Feb 13, 2008 by Rob Shearman Committed by Alexandre Julliard Feb 13, 2008
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

marshal.c dlls/ole32/marshal.c +1 -1

No files found.
--- a/dlls/ole32/marshal.c
+++ b/dlls/ole32/marshal.c
@@ -279,7 +279,7 @@ static HRESULT WINAPI ClientIdentity_QueryMultipleInterfaces(IMultiQI *iface, UL
        /* get IRemUnknown proxy so we can communicate with the remote object */
        hr = proxy_manager_get_remunknown(This, &remunk);

-        if (hr == S_OK)
+        if (SUCCEEDED(hr))
        {
            hr = IRemUnknown_RemQueryInterface(remunk, ipid, NORMALEXTREFS,
                                               nonlocal_mqis, iids, &qiresults);