xactengine3_7: Return valid HRESULT from IXACT3Engine Initialize.

FAudio doesn't always return a valid HRESULT, ensure a valid code is passed back to the application. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

xactengine3_7: Return valid HRESULT from IXACT3Engine Initialize.
47a5de34 · Alistair Leslie-Hughes · Alexandre Julliard · 18d7bc98 · 47a5de34
Commit 47a5de34 authored Aug 04, 2020 by Alistair Leslie-Hughes Committed by Alexandre Julliard Aug 04, 2020
Show whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

xact_dll.c dlls/xactengine3_7/xact_dll.c +6 -1

No files found.
--- a/dlls/xactengine3_7/xact_dll.c
+++ b/dlls/xactengine3_7/xact_dll.c
@@ -157,6 +157,7 @@ static HRESULT WINAPI IXACT3EngineImpl_Initialize(IXACT3Engine *iface,
 {
    XACT3EngineImpl *This = impl_from_IXACT3Engine(iface);
    FACTRuntimeParameters params;
+    UINT ret;

    TRACE("(%p)->(%p)\n", This, pParams);

@@ -195,7 +196,11 @@ static HRESULT WINAPI IXACT3EngineImpl_Initialize(IXACT3Engine *iface,
    params.fileIOCallbacks.readFileCallback = wrap_readfile;
    params.fileIOCallbacks.getOverlappedResultCallback = wrap_getoverlappedresult;

-    return FACTAudioEngine_Initialize(This->fact_engine, &params);
+    ret = FACTAudioEngine_Initialize(This->fact_engine, &params);
+    if (ret != 0)
+        WARN("FACTAudioEngine_Initialize returned %d\n", ret);
+
+    return !ret ? S_OK : E_FAIL;
 }

 static HRESULT WINAPI IXACT3EngineImpl_ShutDown(IXACT3Engine *iface)