Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
47b6d3a1
Commit
47b6d3a1
authored
Sep 20, 2006
by
Dan Hipschman
Committed by
Alexandre Julliard
Sep 21, 2006
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msxml3: Fix IXMLDOMNamedNodeMap_getNamedItem() conformance on error.
parent
4195697c
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
21 additions
and
2 deletions
+21
-2
nodemap.c
dlls/msxml3/nodemap.c
+8
-2
domdoc.c
dlls/msxml3/tests/domdoc.c
+13
-0
No files found.
dlls/msxml3/nodemap.c
View file @
47b6d3a1
...
...
@@ -165,7 +165,10 @@ static HRESULT WINAPI xmlnodemap_getNamedItem(
xmlAttrPtr
attr
;
xmlNodePtr
node
;
TRACE
(
"%p %s
\n
"
,
This
,
debugstr_w
(
name
)
);
TRACE
(
"%p %s %p
\n
"
,
This
,
debugstr_w
(
name
),
namedItem
);
if
(
!
namedItem
)
return
E_INVALIDARG
;
node
=
xmlNodePtr_from_domnode
(
This
->
node
,
0
);
if
(
!
node
)
...
...
@@ -176,7 +179,10 @@ static HRESULT WINAPI xmlnodemap_getNamedItem(
HeapFree
(
GetProcessHeap
(),
0
,
element_name
);
if
(
!
attr
)
return
E_FAIL
;
{
*
namedItem
=
NULL
;
return
S_FALSE
;
}
*
namedItem
=
create_node
(
(
xmlNodePtr
)
attr
);
...
...
dlls/msxml3/tests/domdoc.c
View file @
47b6d3a1
...
...
@@ -396,6 +396,19 @@ todo_wine
IXMLDOMNode_Release
(
node
);
SysFreeString
(
str
);
str
=
SysAllocString
(
szdl
);
r
=
IXMLDOMNamedNodeMap_getNamedItem
(
map
,
str
,
NULL
);
ok
(
r
==
E_INVALIDARG
,
"getNamedItem should return E_INVALIDARG
\n
"
);
SysFreeString
(
str
);
/* something that isn't in szComplete4 */
str
=
SysAllocString
(
szOpen
);
node
=
(
IXMLDOMNode
*
)
1
;
r
=
IXMLDOMNamedNodeMap_getNamedItem
(
map
,
str
,
&
node
);
ok
(
r
=
S_FALSE
,
"getNamedItem found a node that wasn't there
\n
"
);
ok
(
node
==
NULL
,
"getNamedItem should have returned NULL
\n
"
);
SysFreeString
(
str
);
/* test indexed access of attributes */
r
=
IXMLDOMNamedNodeMap_get_length
(
map
,
&
count
);
ok
(
r
==
S_OK
,
"get_length wrong code
\n
"
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment