Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
48cebe2b
Commit
48cebe2b
authored
Oct 11, 2023
by
Alistair Leslie-Hughes
Committed by
Alexandre Julliard
Oct 27, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msxml3: Do not leak bind context on error paths (Coverity).
parent
2e23904a
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
11 deletions
+8
-11
httprequest.c
dlls/msxml3/httprequest.c
+8
-11
No files found.
dlls/msxml3/httprequest.c
View file @
48cebe2b
...
...
@@ -680,19 +680,12 @@ static const IAuthenticateVtbl AuthenticateVtbl = {
static
HRESULT
BindStatusCallback_create
(
httprequest
*
This
,
BindStatusCallback
**
obj
,
const
VARIANT
*
body
)
{
BindStatusCallback
*
bsc
;
IBindCtx
*
pbc
;
IBindCtx
*
pbc
=
NULL
;
HRESULT
hr
;
LONG
size
;
hr
=
CreateBindCtx
(
0
,
&
pbc
);
if
(
hr
!=
S_OK
)
return
hr
;
bsc
=
heap_alloc
(
sizeof
(
*
bsc
));
if
(
!
bsc
)
{
IBindCtx_Release
(
pbc
);
if
(
!
(
bsc
=
heap_alloc
(
sizeof
(
*
bsc
))))
return
E_OUTOFMEMORY
;
}
bsc
->
IBindStatusCallback_iface
.
lpVtbl
=
&
BindStatusCallbackVtbl
;
bsc
->
IHttpNegotiate_iface
.
lpVtbl
=
&
BSCHttpNegotiateVtbl
;
...
...
@@ -795,7 +788,9 @@ static HRESULT BindStatusCallback_create(httprequest* This, BindStatusCallback *
SafeArrayUnaccessData
(
sa
);
}
hr
=
RegisterBindStatusCallback
(
pbc
,
&
bsc
->
IBindStatusCallback_iface
,
NULL
,
0
);
hr
=
CreateBindCtx
(
0
,
&
pbc
);
if
(
hr
==
S_OK
)
hr
=
RegisterBindStatusCallback
(
pbc
,
&
bsc
->
IBindStatusCallback_iface
,
NULL
,
0
);
if
(
hr
==
S_OK
)
{
IMoniker
*
moniker
;
...
...
@@ -809,9 +804,11 @@ static HRESULT BindStatusCallback_create(httprequest* This, BindStatusCallback *
IMoniker_Release
(
moniker
);
if
(
stream
)
IStream_Release
(
stream
);
}
IBindCtx_Release
(
pbc
);
}
if
(
pbc
)
IBindCtx_Release
(
pbc
);
if
(
FAILED
(
hr
))
{
IBindStatusCallback_Release
(
&
bsc
->
IBindStatusCallback_iface
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment