wininet: Cleanup any existing cache file before creating a new one.

Otherwise we leak the file name and handle when a request is sent again. Found by Valgrind.

wininet: Cleanup any existing cache file before creating a new one.
4a22c88b · Hans Leidekker · Alexandre Julliard · 552db89b · 4a22c88b
Commit 4a22c88b authored Dec 07, 2009 by Hans Leidekker Committed by Alexandre Julliard Dec 07, 2009
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

http.c dlls/wininet/http.c +3 -0

No files found.
--- a/dlls/wininet/http.c
+++ b/dlls/wininet/http.c
@@ -3638,6 +3638,9 @@ static DWORD HTTP_HttpSendRequestW(http_request_t *lpwhr, LPCWSTR lpszHeaders,

        b = CreateUrlCacheEntryW(url, lpwhr->dwContentLength > 0 ? lpwhr->dwContentLength : 0, NULL, cacheFileName, 0);
        if(b) {
+            HeapFree(GetProcessHeap(), 0, lpwhr->lpszCacheFile);
+            CloseHandle(lpwhr->hCacheFile);
+
            lpwhr->lpszCacheFile = heap_strdupW(cacheFileName);
            lpwhr->hCacheFile = CreateFileW(lpwhr->lpszCacheFile, GENERIC_WRITE, FILE_SHARE_READ|FILE_SHARE_WRITE,
                      NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);