Commit 4e50b617 authored by Paul Gofman's avatar Paul Gofman Committed by Alexandre Julliard

kernelbase: Don't use LdrLockLoaderLock() in GetModuleHandleExW().

parent 7ddd79b8
...@@ -373,10 +373,9 @@ BOOL WINAPI DECLSPEC_HOTPATCH GetModuleHandleExA( DWORD flags, LPCSTR name, HMOD ...@@ -373,10 +373,9 @@ BOOL WINAPI DECLSPEC_HOTPATCH GetModuleHandleExA( DWORD flags, LPCSTR name, HMOD
*/ */
BOOL WINAPI DECLSPEC_HOTPATCH GetModuleHandleExW( DWORD flags, LPCWSTR name, HMODULE *module ) BOOL WINAPI DECLSPEC_HOTPATCH GetModuleHandleExW( DWORD flags, LPCWSTR name, HMODULE *module )
{ {
NTSTATUS status = STATUS_SUCCESS;
HMODULE ret = NULL; HMODULE ret = NULL;
ULONG_PTR magic; NTSTATUS status;
BOOL lock; void *dummy;
if (!module) if (!module)
{ {
...@@ -394,36 +393,32 @@ BOOL WINAPI DECLSPEC_HOTPATCH GetModuleHandleExW( DWORD flags, LPCWSTR name, HMO ...@@ -394,36 +393,32 @@ BOOL WINAPI DECLSPEC_HOTPATCH GetModuleHandleExW( DWORD flags, LPCWSTR name, HMO
return FALSE; return FALSE;
} }
/* if we are messing with the refcount, grab the loader lock */ if (name && !(flags & GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS))
lock = (flags & GET_MODULE_HANDLE_EX_FLAG_PIN) || !(flags & GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT);
if (lock) LdrLockLoaderLock( 0, NULL, &magic );
if (!name)
{
ret = NtCurrentTeb()->Peb->ImageBaseAddress;
}
else if (flags & GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS)
{
void *dummy;
if (!(ret = RtlPcToFileHeader( (void *)name, &dummy ))) status = STATUS_DLL_NOT_FOUND;
}
else
{ {
UNICODE_STRING wstr; UNICODE_STRING wstr;
ULONG ldr_flags = 0;
if (flags & GET_MODULE_HANDLE_EX_FLAG_PIN)
ldr_flags |= LDR_GET_DLL_HANDLE_EX_FLAG_PIN;
if (flags & GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT)
ldr_flags |= LDR_GET_DLL_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT;
RtlInitUnicodeString( &wstr, name ); RtlInitUnicodeString( &wstr, name );
status = LdrGetDllHandle( NULL, 0, &wstr, &ret ); status = LdrGetDllHandleEx( ldr_flags, NULL, NULL, &wstr, &ret );
} }
else
{
ret = name ? RtlPcToFileHeader( (void *)name, &dummy ) : NtCurrentTeb()->Peb->ImageBaseAddress;
if (status == STATUS_SUCCESS) if (ret)
{ {
if (flags & GET_MODULE_HANDLE_EX_FLAG_PIN) if (!(flags & GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT))
LdrAddRefDll( LDR_ADDREF_DLL_PIN, ret ); status = LdrAddRefDll( flags & GET_MODULE_HANDLE_EX_FLAG_PIN ? LDR_ADDREF_DLL_PIN : 0, ret );
else if (!(flags & GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT)) else
LdrAddRefDll( 0, ret ); status = STATUS_SUCCESS;
} else status = STATUS_DLL_NOT_FOUND;
} }
if (lock) LdrUnlockLoaderLock( 0, magic );
*module = ret; *module = ret;
return set_ntstatus( status ); return set_ntstatus( status );
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment