widl: Fix crash when trying to declare a fixed size array with a size_is attribute.

In this case type_array_get_conformance will return NULL. The code here is actually replacing an existing array with an EXPR_VOID conformance with the specified conformance, so issue an error if type_array_get_conformance returns NULL or the conformance has already been defined.

widl: Fix crash when trying to declare a fixed size array with a size_is attribute.
50534b87 · Rob Shearman · Alexandre Julliard · 096b3cd0 · 50534b87
Commit 50534b87 authored Mar 23, 2010 by Rob Shearman Committed by Alexandre Julliard Mar 23, 2010
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

parser.y tools/widl/parser.y +3 -2

No files found.
--- a/tools/widl/parser.y
+++ b/tools/widl/parser.y
@@ -1514,8 +1514,9 @@ static var_t *declare_var(attr_list_t *attrs, decl_spec_t *decl_spec, const decl
    {
      if (is_array(*ptype))
      {
-        if (type_array_get_conformance(*ptype)->is_const)
-          error_loc("%s: cannot specify size_is for a fixed sized array\n", v->name);
+        if (!type_array_get_conformance(*ptype) ||
+            type_array_get_conformance(*ptype)->type != EXPR_VOID)
+          error_loc("%s: cannot specify size_is for an already sized array\n", v->name);
        else
          *ptype = type_new_array((*ptype)->name,
                                  type_array_get_element(*ptype), FALSE,