Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
51302e01
Commit
51302e01
authored
Nov 10, 2014
by
Michael Stefaniuc
Committed by
Alexandre Julliard
Nov 11, 2014
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
wininet: Simplify the check for an empty string (PVS-Studio).
parent
b91084a9
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
5 deletions
+5
-5
ftp.c
dlls/wininet/ftp.c
+1
-1
internet.c
dlls/wininet/tests/internet.c
+4
-4
No files found.
dlls/wininet/ftp.c
View file @
51302e01
...
@@ -2496,7 +2496,7 @@ HINTERNET FTP_Connect(appinfo_t *hIC, LPCWSTR lpszServerName,
...
@@ -2496,7 +2496,7 @@ HINTERNET FTP_Connect(appinfo_t *hIC, LPCWSTR lpszServerName,
if
(
hIC
->
proxyBypass
)
if
(
hIC
->
proxyBypass
)
FIXME
(
"Proxy bypass is ignored.
\n
"
);
FIXME
(
"Proxy bypass is ignored.
\n
"
);
}
}
if
(
!
lpszUserName
||
!
strlenW
(
lpszUserName
)
)
{
if
(
!
lpszUserName
||
!
lpszUserName
[
0
]
)
{
HKEY
key
;
HKEY
key
;
WCHAR
szPassword
[
MAX_PATH
];
WCHAR
szPassword
[
MAX_PATH
];
DWORD
len
=
sizeof
(
szPassword
);
DWORD
len
=
sizeof
(
szPassword
);
...
...
dlls/wininet/tests/internet.c
View file @
51302e01
...
@@ -1578,7 +1578,7 @@ static void test_InternetGetConnectedStateExA(void)
...
@@ -1578,7 +1578,7 @@ static void test_InternetGetConnectedStateExA(void)
res
=
pInternetGetConnectedStateExA
(
&
flags
,
buffer
,
1
,
0
);
res
=
pInternetGetConnectedStateExA
(
&
flags
,
buffer
,
1
,
0
);
ok
(
res
==
TRUE
,
"Expected TRUE, got %d
\n
"
,
res
);
ok
(
res
==
TRUE
,
"Expected TRUE, got %d
\n
"
,
res
);
ok
(
flags
,
"Expected at least one flag set
\n
"
);
ok
(
flags
,
"Expected at least one flag set
\n
"
);
ok
(
strlen
(
buffer
)
==
0
,
"Expected 0 bytes, got %u
\n
"
,
lstrlenA
(
buffer
));
ok
(
!
buffer
[
0
]
,
"Expected 0 bytes, got %u
\n
"
,
lstrlenA
(
buffer
));
buffer
[
0
]
=
0
;
buffer
[
0
]
=
0
;
flags
=
0
;
flags
=
0
;
...
@@ -1592,7 +1592,7 @@ static void test_InternetGetConnectedStateExA(void)
...
@@ -1592,7 +1592,7 @@ static void test_InternetGetConnectedStateExA(void)
res
=
pInternetGetConnectedStateExA
(
&
flags
,
buffer
,
1
,
0
);
res
=
pInternetGetConnectedStateExA
(
&
flags
,
buffer
,
1
,
0
);
ok
(
res
==
TRUE
,
"Expected TRUE, got %d
\n
"
,
res
);
ok
(
res
==
TRUE
,
"Expected TRUE, got %d
\n
"
,
res
);
ok
(
flags
,
"Expected at least one flag set
\n
"
);
ok
(
flags
,
"Expected at least one flag set
\n
"
);
ok
(
strlen
(
buffer
)
==
0
,
"Expected 0 bytes, got %u
\n
"
,
lstrlenA
(
buffer
));
ok
(
!
buffer
[
0
]
,
"Expected 0 bytes, got %u
\n
"
,
lstrlenA
(
buffer
));
}
}
static
void
test_InternetGetConnectedStateExW
(
void
)
static
void
test_InternetGetConnectedStateExW
(
void
)
...
@@ -1667,7 +1667,7 @@ static void test_InternetGetConnectedStateExW(void)
...
@@ -1667,7 +1667,7 @@ static void test_InternetGetConnectedStateExW(void)
res
=
pInternetGetConnectedStateExW
(
&
flags
,
buffer
,
1
,
0
);
res
=
pInternetGetConnectedStateExW
(
&
flags
,
buffer
,
1
,
0
);
ok
(
res
==
TRUE
,
"Expected TRUE, got %d
\n
"
,
res
);
ok
(
res
==
TRUE
,
"Expected TRUE, got %d
\n
"
,
res
);
ok
(
flags
,
"Expected at least one flag set
\n
"
);
ok
(
flags
,
"Expected at least one flag set
\n
"
);
ok
(
lstrlenW
(
buffer
)
==
0
,
"Expected 0 bytes, got %u
\n
"
,
lstrlenW
(
buffer
));
ok
(
!
buffer
[
0
]
,
"Expected 0 bytes, got %u
\n
"
,
lstrlenW
(
buffer
));
buffer
[
0
]
=
0
;
buffer
[
0
]
=
0
;
flags
=
0
;
flags
=
0
;
...
@@ -1681,7 +1681,7 @@ static void test_InternetGetConnectedStateExW(void)
...
@@ -1681,7 +1681,7 @@ static void test_InternetGetConnectedStateExW(void)
res
=
pInternetGetConnectedStateExW
(
&
flags
,
buffer
,
1
,
0
);
res
=
pInternetGetConnectedStateExW
(
&
flags
,
buffer
,
1
,
0
);
ok
(
res
==
TRUE
,
"Expected TRUE, got %d
\n
"
,
res
);
ok
(
res
==
TRUE
,
"Expected TRUE, got %d
\n
"
,
res
);
ok
(
flags
,
"Expected at least one flag set
\n
"
);
ok
(
flags
,
"Expected at least one flag set
\n
"
);
ok
(
lstrlenW
(
buffer
)
==
0
,
"Expected 0 bytes, got %u
\n
"
,
lstrlenW
(
buffer
));
ok
(
!
buffer
[
0
]
,
"Expected 0 bytes, got %u
\n
"
,
lstrlenW
(
buffer
));
}
}
/* ############################### */
/* ############################### */
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment