xmllite: Free elem in error paths (Coverity).

51d96dac · Marcus Meissner · Alexandre Julliard · af18f3e0 · 51d96dac
Commit 51d96dac authored May 09, 2013 by Marcus Meissner Committed by Alexandre Julliard May 09, 2013
Show whitespace changes
Inline Side-by-side

Showing with 8 additions and 2 deletions

reader.c dlls/xmllite/reader.c +8 -2

No files found.
--- a/dlls/xmllite/reader.c
+++ b/dlls/xmllite/reader.c
@@ -379,12 +379,18 @@ static HRESULT reader_push_element(xmlreader *reader, strval *qname)
    if (!elem) return E_OUTOFMEMORY;

    hr = reader_strvaldup(reader, qname, &elem->qname);
-    if (FAILED(hr)) return hr;
+    if (FAILED(hr)) {
+        reader_free(reader, elem);
+        return hr;
+    }

    if (!list_empty(&reader->elements))
    {
        hr = reader_inc_depth(reader);
-        if (FAILED(hr)) return hr;
+        if (FAILED(hr)) {
+             reader_free(reader, elem);
+             return hr;
+        }
    }

    list_add_head(&reader->elements, &elem->entry);