msvcrt: Optimize _strupr implementation in C locale.

Don't write to input buffer when there's nothing to change. Signed-off-by: Piotr Caban <piotr@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

msvcrt: Optimize _strupr implementation in C locale.
52415cab · Piotr Caban · Alexandre Julliard · 1184f9d9 · 52415cab
Commit 52415cab authored Mar 22, 2018 by Piotr Caban Committed by Alexandre Julliard Mar 22, 2018
Show whitespace changes
Inline Side-by-side

Showing with 18 additions and 0 deletions

string.c dlls/msvcrt/string.c +18 -0

No files found.
--- a/dlls/msvcrt/string.c
+++ b/dlls/msvcrt/string.c
@@ -117,6 +117,7 @@ char* CDECL MSVCRT__strlwr(char *str)
 */
 int CDECL MSVCRT__strupr_s_l(char *str, MSVCRT_size_t len, MSVCRT__locale_t locale)
 {
+    MSVCRT_pthreadlocinfo locinfo;
    char *ptr = str;

    if (!str || !len)
@@ -138,11 +139,28 @@ int CDECL MSVCRT__strupr_s_l(char *str, MSVCRT_size_t len, MSVCRT__locale_t loca
        return MSVCRT_EINVAL;
    }

+    if(!locale)
+        locinfo = get_locinfo();
+    else
+        locinfo = locale->locinfo;
+
+    if(!locinfo->lc_handle[MSVCRT_LC_CTYPE])
+    {
+        while (*str)
+        {
+            if (*str >= 'a' && *str <= 'z')
+                *str -= 'a' - 'A';
+            str++;
+        }
+    }
+    else
+    {
        while (*str)
        {
            *str = MSVCRT__toupper_l((unsigned char)*str, locale);
            str++;
        }
+    }

    return 0;
 }