dinput: Prevent a device interface leak when enumerating.

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=36263Signed-off-by: Rémi Bernon <rbernon@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

dinput: Prevent a device interface leak when enumerating.
52aacd23 · Rémi Bernon · Alexandre Julliard · d666aea3 · 52aacd23
Commit 52aacd23 authored May 31, 2021 by Rémi Bernon Committed by Alexandre Julliard May 31, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

dinput_main.c dlls/dinput/dinput_main.c +6 -0

No files found.
--- a/dlls/dinput/dinput_main.c
+++ b/dlls/dinput/dinput_main.c
@@ -864,8 +864,10 @@ static HRESULT WINAPI IDirectInput8WImpl_EnumDevicesBySemantics(
        if (lpCallback(&didevis[i], lpdid, callbackFlags, --remain, pvRef) == DIENUM_STOP)
        {
            HeapFree(GetProcessHeap(), 0, didevis);
+            IDirectInputDevice_Release(lpdid);
            return DI_OK;
        }
+        IDirectInputDevice_Release(lpdid);
    }

    HeapFree(GetProcessHeap(), 0, didevis);
@@ -883,7 +885,11 @@ static HRESULT WINAPI IDirectInput8WImpl_EnumDevicesBySemantics(
            IDirectInputDevice_GetDeviceInfo(lpdid, &didevi);

            if (lpCallback(&didevi, lpdid, callbackFlags, --remain, pvRef) == DIENUM_STOP)
+            {
+                IDirectInputDevice_Release(lpdid);
                return DI_OK;
+            }
+            IDirectInputDevice_Release(lpdid);
        }
    }