hnetcfg: Add stub implementations of INetFwOpenPorts and INetFwOpenPort.

dlls/hnetcfg/Makefile.in

@@ -10,6 +10,7 @@ C_SRCS = \
 	hnetcfg.c \
 	manager.c \
 	policy.c \
+	port.c \
 	profile.c \
 	regsvr.c
 

dlls/hnetcfg/hnetcfg_private.h

@@ -21,3 +21,4 @@ HRESULT NetFwPolicy_create(IUnknown *, LPVOID *);
 HRESULT NetFwProfile_create(IUnknown *, LPVOID *);
 HRESULT NetFwAuthorizedApplication_create(IUnknown *, LPVOID *);
 HRESULT NetFwAuthorizedApplications_create(IUnknown *, LPVOID *);
+HRESULT NetFwOpenPorts_create(IUnknown *, LPVOID *);

dlls/hnetcfg/port.c

+/*
+ * Copyright 2009 Hans Leidekker for CodeWeavers
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
+ */
+
+#include "config.h"
+#include <stdarg.h>
+#include <stdio.h>
+
+#define COBJMACROS
+
+#include "windef.h"
+#include "winbase.h"
+#include "winuser.h"
+#include "ole2.h"
+#include "netfw.h"
+
+#include "wine/debug.h"
+#include "wine/unicode.h"
+#include "hnetcfg_private.h"
+
+WINE_DEFAULT_DEBUG_CHANNEL(hnetcfg);
+
+typedef struct fw_port
+{
+    const INetFwOpenPortVtbl *vtbl;
+    LONG refs;
+} fw_port;
+
+static inline fw_port *impl_from_INetFwOpenPort( INetFwOpenPort *iface )
+{
+    return (fw_port *)((char *)iface - FIELD_OFFSET( fw_port, vtbl ));
+}
+
+static ULONG WINAPI fw_port_AddRef(
+    INetFwOpenPort *iface )
+{
+    fw_port *fw_port = impl_from_INetFwOpenPort( iface );
+    return InterlockedIncrement( &fw_port->refs );
+}
+
+static ULONG WINAPI fw_port_Release(
+    INetFwOpenPort *iface )
+{
+    fw_port *fw_port = impl_from_INetFwOpenPort( iface );
+    LONG refs = InterlockedDecrement( &fw_port->refs );
+    if (!refs)
+    {
+        TRACE("destroying %p\n", fw_port);
+        HeapFree( GetProcessHeap(), 0, fw_port );
+    }
+    return refs;
+}
+
+static HRESULT WINAPI fw_port_QueryInterface(
+    INetFwOpenPort *iface,
+    REFIID riid,
+    void **ppvObject )
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    TRACE("%p %s %p\n", This, debugstr_guid( riid ), ppvObject );
+
+    if ( IsEqualGUID( riid, &IID_INetFwOpenPort ) ||
+         IsEqualGUID( riid, &IID_IDispatch ) ||
+         IsEqualGUID( riid, &IID_IUnknown ) )
+    {
+        *ppvObject = iface;
+    }
+    else
+    {
+        FIXME("interface %s not implemented\n", debugstr_guid(riid));
+        return E_NOINTERFACE;
+    }
+    INetFwOpenPort_AddRef( iface );
+    return S_OK;
+}
+
+static HRESULT WINAPI fw_port_GetTypeInfoCount(
+    INetFwOpenPort *iface,
+    UINT *pctinfo )
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    FIXME("%p %p\n", This, pctinfo);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_port_GetTypeInfo(
+    INetFwOpenPort *iface,
+    UINT iTInfo,
+    LCID lcid,
+    ITypeInfo **ppTInfo )
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    FIXME("%p %u %u %p\n", This, iTInfo, lcid, ppTInfo);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_port_GetIDsOfNames(
+    INetFwOpenPort *iface,
+    REFIID riid,
+    LPOLESTR *rgszNames,
+    UINT cNames,
+    LCID lcid,
+    DISPID *rgDispId )
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    FIXME("%p %s %p %u %u %p\n", This, debugstr_guid(riid), rgszNames, cNames, lcid, rgDispId);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_port_Invoke(
+    INetFwOpenPort *iface,
+    DISPID dispIdMember,
+    REFIID riid,
+    LCID lcid,
+    WORD wFlags,
+    DISPPARAMS *pDispParams,
+    VARIANT *pVarResult,
+    EXCEPINFO *pExcepInfo,
+    UINT *puArgErr )
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    FIXME("%p %d %s %d %d %p %p %p %p\n", This, dispIdMember, debugstr_guid(riid),
+          lcid, wFlags, pDispParams, pVarResult, pExcepInfo, puArgErr);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_port_get_Name(
+    INetFwOpenPort *iface,
+    BSTR *name)
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    FIXME("%p %p\n", This, name);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_port_put_Name(
+    INetFwOpenPort *iface,
+    BSTR name)
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    FIXME("%p %s\n", This, debugstr_w(name));
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_port_get_IpVersion(
+    INetFwOpenPort *iface,
+    NET_FW_IP_VERSION *ipVersion)
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    FIXME("%p %p\n", This, ipVersion);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_port_put_IpVersion(
+    INetFwOpenPort *iface,
+    NET_FW_IP_VERSION ipVersion)
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    FIXME("%p %u\n", This, ipVersion);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_port_get_Protocol(
+    INetFwOpenPort *iface,
+    NET_FW_IP_PROTOCOL *ipProtocol)
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    FIXME("%p %p\n", This, ipProtocol);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_port_put_Protocol(
+    INetFwOpenPort *iface,
+    NET_FW_IP_PROTOCOL ipProtocol)
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    FIXME("%p %u\n", This, ipProtocol);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_port_get_Port(
+    INetFwOpenPort *iface,
+    LONG *portNumber)
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    FIXME("%p %p\n", This, portNumber);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_port_put_Port(
+    INetFwOpenPort *iface,
+    LONG portNumber)
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    FIXME("%p %d\n", This, portNumber);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_port_get_Scope(
+    INetFwOpenPort *iface,
+    NET_FW_SCOPE *scope)
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    FIXME("%p %p\n", This, scope);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_port_put_Scope(
+    INetFwOpenPort *iface,
+    NET_FW_SCOPE scope)
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    FIXME("%p %u\n", This, scope);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_port_get_RemoteAddresses(
+    INetFwOpenPort *iface,
+    BSTR *remoteAddrs)
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    FIXME("%p %p\n", This, remoteAddrs);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_port_put_RemoteAddresses(
+    INetFwOpenPort *iface,
+    BSTR remoteAddrs)
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    FIXME("%p %s\n", This, debugstr_w(remoteAddrs));
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_port_get_Enabled(
+    INetFwOpenPort *iface,
+    VARIANT_BOOL *enabled)
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    FIXME("%p %p\n", This, enabled);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_port_put_Enabled(
+    INetFwOpenPort *iface,
+    VARIANT_BOOL enabled)
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    FIXME("%p %d\n", This, enabled);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_port_get_BuiltIn(
+    INetFwOpenPort *iface,
+    VARIANT_BOOL *builtIn)
+{
+    fw_port *This = impl_from_INetFwOpenPort( iface );
+
+    FIXME("%p %p\n", This, builtIn);
+    return E_NOTIMPL;
+}
+
+static const struct INetFwOpenPortVtbl fw_port_vtbl =
+{
+    fw_port_QueryInterface,
+    fw_port_AddRef,
+    fw_port_Release,
+    fw_port_GetTypeInfoCount,
+    fw_port_GetTypeInfo,
+    fw_port_GetIDsOfNames,
+    fw_port_Invoke,
+    fw_port_get_Name,
+    fw_port_put_Name,
+    fw_port_get_IpVersion,
+    fw_port_put_IpVersion,
+    fw_port_get_Protocol,
+    fw_port_put_Protocol,
+    fw_port_get_Port,
+    fw_port_put_Port,
+    fw_port_get_Scope,
+    fw_port_put_Scope,
+    fw_port_get_RemoteAddresses,
+    fw_port_put_RemoteAddresses,
+    fw_port_get_Enabled,
+    fw_port_put_Enabled,
+    fw_port_get_BuiltIn
+};
+
+HRESULT NetFwOpenPort_create( IUnknown *pUnkOuter, LPVOID *ppObj )
+{
+    fw_port *fp;
+
+    TRACE("(%p,%p)\n", pUnkOuter, ppObj);
+
+    fp = HeapAlloc( GetProcessHeap(), 0, sizeof(*fp) );
+    if (!fp) return E_OUTOFMEMORY;
+
+    fp->vtbl = &fw_port_vtbl;
+    fp->refs = 1;
+
+    *ppObj = &fp->vtbl;
+
+    TRACE("returning iface %p\n", *ppObj);
+    return S_OK;
+}
+
+typedef struct fw_ports
+{
+    const INetFwOpenPortsVtbl *vtbl;
+    LONG refs;
+} fw_ports;
+
+static inline fw_ports *impl_from_INetFwOpenPorts( INetFwOpenPorts *iface )
+{
+    return (fw_ports *)((char *)iface - FIELD_OFFSET( fw_ports, vtbl ));
+}
+
+static ULONG WINAPI fw_ports_AddRef(
+    INetFwOpenPorts *iface )
+{
+    fw_ports *fw_ports = impl_from_INetFwOpenPorts( iface );
+    return InterlockedIncrement( &fw_ports->refs );
+}
+
+static ULONG WINAPI fw_ports_Release(
+    INetFwOpenPorts *iface )
+{
+    fw_ports *fw_ports = impl_from_INetFwOpenPorts( iface );
+    LONG refs = InterlockedDecrement( &fw_ports->refs );
+    if (!refs)
+    {
+        TRACE("destroying %p\n", fw_ports);
+        HeapFree( GetProcessHeap(), 0, fw_ports );
+    }
+    return refs;
+}
+
+static HRESULT WINAPI fw_ports_QueryInterface(
+    INetFwOpenPorts *iface,
+    REFIID riid,
+    void **ppvObject )
+{
+    fw_ports *This = impl_from_INetFwOpenPorts( iface );
+
+    TRACE("%p %s %p\n", This, debugstr_guid( riid ), ppvObject );
+
+    if ( IsEqualGUID( riid, &IID_INetFwOpenPorts ) ||
+         IsEqualGUID( riid, &IID_IDispatch ) ||
+         IsEqualGUID( riid, &IID_IUnknown ) )
+    {
+        *ppvObject = iface;
+    }
+    else
+    {
+        FIXME("interface %s not implemented\n", debugstr_guid(riid));
+        return E_NOINTERFACE;
+    }
+    INetFwOpenPorts_AddRef( iface );
+    return S_OK;
+}
+
+static HRESULT WINAPI fw_ports_GetTypeInfoCount(
+    INetFwOpenPorts *iface,
+    UINT *pctinfo )
+{
+    fw_ports *This = impl_from_INetFwOpenPorts( iface );
+
+    FIXME("%p %p\n", This, pctinfo);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_ports_GetTypeInfo(
+    INetFwOpenPorts *iface,
+    UINT iTInfo,
+    LCID lcid,
+    ITypeInfo **ppTInfo )
+{
+    fw_ports *This = impl_from_INetFwOpenPorts( iface );
+
+    FIXME("%p %u %u %p\n", This, iTInfo, lcid, ppTInfo);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_ports_GetIDsOfNames(
+    INetFwOpenPorts *iface,
+    REFIID riid,
+    LPOLESTR *rgszNames,
+    UINT cNames,
+    LCID lcid,
+    DISPID *rgDispId )
+{
+    fw_ports *This = impl_from_INetFwOpenPorts( iface );
+
+    FIXME("%p %s %p %u %u %p\n", This, debugstr_guid(riid), rgszNames, cNames, lcid, rgDispId);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_ports_Invoke(
+    INetFwOpenPorts *iface,
+    DISPID dispIdMember,
+    REFIID riid,
+    LCID lcid,
+    WORD wFlags,
+    DISPPARAMS *pDispParams,
+    VARIANT *pVarResult,
+    EXCEPINFO *pExcepInfo,
+    UINT *puArgErr )
+{
+    fw_ports *This = impl_from_INetFwOpenPorts( iface );
+
+    FIXME("%p %d %s %d %d %p %p %p %p\n", This, dispIdMember, debugstr_guid(riid),
+          lcid, wFlags, pDispParams, pVarResult, pExcepInfo, puArgErr);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_ports_get_Count(
+    INetFwOpenPorts *iface,
+    LONG *count)
+{
+    fw_ports *This = impl_from_INetFwOpenPorts( iface );
+
+    FIXME("%p, %p\n", This, count);
+
+    *count = 0;
+    return S_OK;
+}
+
+static HRESULT WINAPI fw_ports_Add(
+    INetFwOpenPorts *iface,
+    INetFwOpenPort *port)
+{
+    fw_ports *This = impl_from_INetFwOpenPorts( iface );
+
+    FIXME("%p, %p\n", This, port);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_ports_Remove(
+    INetFwOpenPorts *iface,
+    LONG portNumber,
+    NET_FW_IP_PROTOCOL ipProtocol)
+{
+    fw_ports *This = impl_from_INetFwOpenPorts( iface );
+
+    FIXME("%p, %d, %u\n", This, portNumber, ipProtocol);
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI fw_ports_Item(
+    INetFwOpenPorts *iface,
+    LONG portNumber,
+    NET_FW_IP_PROTOCOL ipProtocol,
+    INetFwOpenPort **openPort)
+{
+    HRESULT hr;
+    fw_ports *This = impl_from_INetFwOpenPorts( iface );
+
+    FIXME("%p, %d, %u, %p\n", This, portNumber, ipProtocol, openPort);
+
+    hr = NetFwOpenPort_create( NULL, (void **)openPort );
+    if (SUCCEEDED(hr))
+    {
+        INetFwOpenPort_put_Protocol( *openPort, ipProtocol );
+        INetFwOpenPort_put_Port( *openPort, portNumber );
+    }
+    return hr;
+}
+
+static HRESULT WINAPI fw_ports_get__NewEnum(
+    INetFwOpenPorts *iface,
+    IUnknown **newEnum)
+{
+    fw_ports *This = impl_from_INetFwOpenPorts( iface );
+
+    FIXME("%p, %p\n", This, newEnum);
+    return E_NOTIMPL;
+}
+
+static const struct INetFwOpenPortsVtbl fw_ports_vtbl =
+{
+    fw_ports_QueryInterface,
+    fw_ports_AddRef,
+    fw_ports_Release,
+    fw_ports_GetTypeInfoCount,
+    fw_ports_GetTypeInfo,
+    fw_ports_GetIDsOfNames,
+    fw_ports_Invoke,
+    fw_ports_get_Count,
+    fw_ports_Add,
+    fw_ports_Remove,
+    fw_ports_Item,
+    fw_ports_get__NewEnum
+};
+
+HRESULT NetFwOpenPorts_create( IUnknown *pUnkOuter, LPVOID *ppObj )
+{
+    fw_ports *fp;
+
+    TRACE("(%p,%p)\n", pUnkOuter, ppObj);
+
+    fp = HeapAlloc( GetProcessHeap(), 0, sizeof(*fp) );
+    if (!fp) return E_OUTOFMEMORY;
+
+    fp->vtbl = &fw_ports_vtbl;
+    fp->refs = 1;
+
+    *ppObj = &fp->vtbl;
+
+    TRACE("returning iface %p\n", *ppObj);
+    return S_OK;
+}

dlls/hnetcfg/profile.c

@@ -261,8 +261,8 @@ static HRESULT WINAPI fw_profile_get_GloballyOpenPorts(
 {
     fw_profile *This = impl_from_INetFwProfile( iface );
 
-    FIXME("%p, %p\n", This, openPorts);
-    return E_NOTIMPL;
+    TRACE("%p, %p\n", This, openPorts);
+    return NetFwOpenPorts_create( NULL, (void **)openPorts );
 }
 
 static HRESULT WINAPI fw_profile_get_Services(