mshtml: Fix nsparser leak if script_elem_from_nsscript failed.

Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>

mshtml: Fix nsparser leak if script_elem_from_nsscript failed.
541257b0 · Gabriel Ivăncescu · Alexandre Julliard · fb0b55c5 · 541257b0
Commit 541257b0 authored Mar 20, 2023 by Gabriel Ivăncescu Committed by Alexandre Julliard Mar 20, 2023
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

mutation.c dlls/mshtml/mutation.c +4 -1

No files found.
--- a/dlls/mshtml/mutation.c
+++ b/dlls/mshtml/mutation.c
@@ -352,8 +352,11 @@ static nsresult run_insert_script(HTMLDocumentNode *doc, nsISupports *script_ifa

    hres = script_elem_from_nsscript(nsscript, &script_elem);
    nsIDOMHTMLScriptElement_Release(nsscript);
-    if(FAILED(hres))
+    if(FAILED(hres)) {
+        if(nsparser)
+            nsIParser_Release(nsparser);
        return NS_ERROR_FAILURE;
+    }

    if(nsparser) {
        nsIParser_BeginEvaluatingParserInsertedScript(nsparser);