xmllite/writer: Null terminate duplicated strings.

Strings are not being "partially duplicated", but duplicated with explicit length. Signed-off-by: David Kahurani <k.kahurani@gmail.com>

xmllite/writer: Null terminate duplicated strings.
556b3981 · David Kahurani · Alexandre Julliard · e3f00bf7 · 556b3981
Commit 556b3981 authored Oct 10, 2022 by David Kahurani Committed by Alexandre Julliard Oct 17, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 4 deletions

writer.c dlls/xmllite/writer.c +6 -4

No files found.
--- a/dlls/xmllite/writer.c
+++ b/dlls/xmllite/writer.c
@@ -250,7 +250,6 @@ static struct element *pop_element(xmlwriter *writer)

 static WCHAR *writer_strndupW(const xmlwriter *writer, const WCHAR *str, int len)
 {
-    size_t size;
    WCHAR *ret;

    if (!str)
@@ -259,9 +258,12 @@ static WCHAR *writer_strndupW(const xmlwriter *writer, const WCHAR *str, int len
    if (len == -1)
        len = lstrlenW(str);

-    size = (len + 1) * sizeof(WCHAR);
-    ret = writer_alloc(writer, size);
-    if (ret) memcpy(ret, str, size);
+    ret = writer_alloc(writer, (len + 1) * sizeof(WCHAR));
+    if (ret)
+    {
+        memcpy(ret, str, len * sizeof(WCHAR));
+        ret[len] = 0;
+    }

    return ret;
 }