Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
59247cf9
Commit
59247cf9
authored
Dec 11, 2012
by
Hans Leidekker
Committed by
Alexandre Julliard
Dec 11, 2012
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
wininet: Don't perform revocation checks when verifying a certificate.
parent
441780b2
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
31 deletions
+3
-31
netconnection.c
dlls/wininet/netconnection.c
+3
-31
No files found.
dlls/wininet/netconnection.c
View file @
59247cf9
...
...
@@ -222,25 +222,19 @@ static DWORD netconn_verify_cert(netconn_t *conn, PCCERT_CONTEXT cert, HCERTSTOR
PCCERT_CHAIN_CONTEXT
chain
;
char
oid_server_auth
[]
=
szOID_PKIX_KP_SERVER_AUTH
;
char
*
server_auth
[]
=
{
oid_server_auth
};
DWORD
err
=
ERROR_SUCCESS
,
chainFlags
=
0
,
errors
;
DWORD
err
=
ERROR_SUCCESS
,
errors
;
static
const
DWORD
supportedErrors
=
CERT_TRUST_IS_NOT_TIME_VALID
|
CERT_TRUST_IS_UNTRUSTED_ROOT
|
CERT_TRUST_IS_PARTIAL_CHAIN
|
CERT_TRUST_IS_OFFLINE_REVOCATION
|
CERT_TRUST_REVOCATION_STATUS_UNKNOWN
|
CERT_TRUST_IS_REVOKED
|
CERT_TRUST_IS_NOT_VALID_FOR_USAGE
;
TRACE
(
"verifying %s
\n
"
,
debugstr_w
(
conn
->
server
->
name
));
chainPara
.
RequestedUsage
.
Usage
.
cUsageIdentifier
=
1
;
chainPara
.
RequestedUsage
.
Usage
.
rgpszUsageIdentifier
=
server_auth
;
if
(
!
(
conn
->
security_flags
&
SECURITY_FLAG_IGNORE_REVOCATION
))
chainFlags
|=
CERT_CHAIN_REVOCATION_CHECK_CHAIN_EXCLUDE_ROOT
;
if
(
!
(
ret
=
CertGetCertificateChain
(
NULL
,
cert
,
NULL
,
store
,
&
chainPara
,
chainFlags
,
NULL
,
&
chain
)))
{
if
(
!
(
ret
=
CertGetCertificateChain
(
NULL
,
cert
,
NULL
,
store
,
&
chainPara
,
0
,
NULL
,
&
chain
)))
{
TRACE
(
"failed
\n
"
);
return
GetLastError
();
}
...
...
@@ -249,7 +243,7 @@ static DWORD netconn_verify_cert(netconn_t *conn, PCCERT_CONTEXT cert, HCERTSTOR
do
{
/* This seems strange, but that's what tests show */
if
(
errors
&
(
CERT_TRUST_IS_PARTIAL_CHAIN
|
CERT_TRUST_IS_OFFLINE_REVOCATION
)
)
{
if
(
errors
&
CERT_TRUST_IS_PARTIAL_CHAIN
)
{
WARN
(
"ERROR_INTERNET_SEC_CERT_REV_FAILED
\n
"
);
err
=
ERROR_INTERNET_SEC_CERT_REV_FAILED
;
if
(
conn
->
mask_errors
)
...
...
@@ -300,28 +294,6 @@ static DWORD netconn_verify_cert(netconn_t *conn, PCCERT_CONTEXT cert, HCERTSTOR
errors
&=
~
CERT_TRUST_IS_PARTIAL_CHAIN
;
}
if
(
errors
&
(
CERT_TRUST_IS_OFFLINE_REVOCATION
|
CERT_TRUST_REVOCATION_STATUS_UNKNOWN
))
{
WARN
(
"CERT_TRUST_IS_OFFLINE_REVOCATION | CERT_TRUST_REVOCATION_STATUS_UNKNOWN
\n
"
);
if
(
!
(
conn
->
security_flags
&
SECURITY_FLAG_IGNORE_REVOCATION
))
{
err
=
conn
->
mask_errors
&&
err
?
ERROR_INTERNET_SEC_CERT_ERRORS
:
ERROR_INTERNET_SEC_CERT_NO_REV
;
if
(
!
conn
->
mask_errors
)
break
;
conn
->
security_flags
|=
_SECURITY_FLAG_CERT_REV_FAILED
;
}
errors
&=
~
(
CERT_TRUST_IS_OFFLINE_REVOCATION
|
CERT_TRUST_REVOCATION_STATUS_UNKNOWN
);
}
if
(
errors
&
CERT_TRUST_IS_REVOKED
)
{
WARN
(
"CERT_TRUST_IS_REVOKED
\n
"
);
if
(
!
(
conn
->
security_flags
&
SECURITY_FLAG_IGNORE_REVOCATION
))
{
err
=
conn
->
mask_errors
&&
err
?
ERROR_INTERNET_SEC_CERT_ERRORS
:
ERROR_INTERNET_SEC_CERT_REVOKED
;
if
(
!
conn
->
mask_errors
)
break
;
WARN
(
"TRUST_IS_OFFLINE_REVOCATION | CERT_TRUST_REVOCATION_STATUS_UNKNOWN, unknown error flags
\n
"
);
}
errors
&=
~
CERT_TRUST_IS_REVOKED
;
}
if
(
errors
&
CERT_TRUST_IS_NOT_VALID_FOR_USAGE
)
{
WARN
(
"CERT_TRUST_IS_NOT_VALID_FOR_USAGE
\n
"
);
if
(
!
(
conn
->
security_flags
&
SECURITY_FLAG_IGNORE_WRONG_USAGE
))
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment