MSDN states that the pszDisplayName member of BROWSEINFO is assumed to

be MAX_PATH in length. So when doing the A->W conversion in BrowseForFolderA do not set that member to be the size of the incoming string, instead make it MAX_PATH.

MSDN states that the pszDisplayName member of BROWSEINFO is assumed to
5a8d7674 · Aric Stewart · Alexandre Julliard · 9577e5e2 · 5a8d7674
Commit 5a8d7674 authored Oct 17, 2005 by Aric Stewart Committed by Alexandre Julliard Oct 17, 2005
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 3 deletions

brsfolder.c dlls/shell32/brsfolder.c +2 -3

No files found.
--- a/dlls/shell32/brsfolder.c
+++ b/dlls/shell32/brsfolder.c
@@ -627,9 +627,8 @@ LPITEMIDLIST WINAPI SHBrowseForFolderA (LPBROWSEINFOA lpbi)
    bi.pidlRoot = lpbi->pidlRoot;
    if (lpbi->pszDisplayName)
    {
-        len = MultiByteToWideChar( CP_ACP, 0, lpbi->pszDisplayName, -1, NULL, 0 );
-        bi.pszDisplayName = HeapAlloc( GetProcessHeap(), 0, len * sizeof(WCHAR) );
-        MultiByteToWideChar( CP_ACP, 0, lpbi->pszDisplayName, -1, bi.pszDisplayName, len );
+        bi.pszDisplayName = HeapAlloc( GetProcessHeap(), 0, MAX_PATH * sizeof(WCHAR) );
+        MultiByteToWideChar( CP_ACP, 0, lpbi->pszDisplayName, -1, bi.pszDisplayName, MAX_PATH );
    }
    else
        bi.pszDisplayName = NULL;