Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
5b8a375a
Commit
5b8a375a
authored
May 24, 2013
by
Alistair Leslie-Hughes
Committed by
Alexandre Julliard
May 27, 2013
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
oledb32: Check for DBSTATUS_S_ISNULL first.
parent
a1baa22d
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
21 additions
and
5 deletions
+21
-5
convert.c
dlls/oledb32/convert.c
+5
-5
convert.c
dlls/oledb32/tests/convert.c
+16
-0
No files found.
dlls/oledb32/convert.c
View file @
5b8a375a
...
...
@@ -179,11 +179,6 @@ static HRESULT WINAPI convert_DataConvert(IDataConvert* iface,
*
dst_status
=
DBSTATUS_E_BADACCESSOR
;
if
(
IDataConvert_CanConvert
(
iface
,
src_type
,
dst_type
)
!=
S_OK
)
{
return
DB_E_UNSUPPORTEDCONVERSION
;
}
if
(
src_status
==
DBSTATUS_S_ISNULL
)
{
*
dst_status
=
DBSTATUS_S_ISNULL
;
...
...
@@ -191,6 +186,11 @@ static HRESULT WINAPI convert_DataConvert(IDataConvert* iface,
return
S_OK
;
}
if
(
IDataConvert_CanConvert
(
iface
,
src_type
,
dst_type
)
!=
S_OK
)
{
return
DB_E_UNSUPPORTEDCONVERSION
;
}
if
(
dst
==
NULL
&&
get_length
(
dst_type
)
!=
0
)
{
*
dst_len
=
get_length
(
src_type
);
...
...
dlls/oledb32/tests/convert.c
View file @
5b8a375a
...
...
@@ -2714,6 +2714,21 @@ static void test_converttotimestamp(void)
SysFreeString
(
bstr
);
}
static
void
test_converttoiunknown
(
void
)
{
HRESULT
hr
;
DBSTATUS
dst_status
;
DBLENGTH
dst_len
;
IUnknown
*
dst
=
NULL
;
static
WCHAR
strW
[]
=
{
't'
,
'e'
,
's'
,
't'
,
0
};
dst_len
=
0x1234
;
hr
=
IDataConvert_DataConvert
(
convert
,
DBTYPE_WSTR
,
DBTYPE_IUNKNOWN
,
sizeof
(
strW
),
&
dst_len
,
strW
,
dst
,
sizeof
(
dst
),
DBSTATUS_S_ISNULL
,
&
dst_status
,
0
,
0
,
0
);
ok
(
hr
==
S_OK
,
"got %08x
\n
"
,
hr
);
ok
(
dst_status
==
DBSTATUS_S_ISNULL
,
"got %08x
\n
"
,
dst_status
);
ok
(
dst_len
==
0
,
"got %ld
\n
"
,
dst_len
);
}
START_TEST
(
convert
)
{
HRESULT
hr
;
...
...
@@ -2751,6 +2766,7 @@ START_TEST(convert)
test_converttodbdate
();
test_getconversionsize
();
test_converttotimestamp
();
test_converttoiunknown
();
IDataConvert_Release
(
convert
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment