Release parent shell folder in GetAttributesOf.

5dd3e481 · Michael Jung · Alexandre Julliard · a51dcfcf · 5dd3e481 · 5dd3e481
Commit 5dd3e481 authored Jul 11, 2005 by Michael Jung Committed by Alexandre Julliard Jul 11, 2005
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 2 deletions

shfldr_fs.c dlls/shell32/shfldr_fs.c +3 -1

shfldr_mycomp.c dlls/shell32/shfldr_mycomp.c +3 -1

No files found.
--- a/dlls/shell32/shfldr_fs.c
+++ b/dlls/shell32/shfldr_fs.c
@@ -590,8 +590,10 @@ IShellFolder_fnGetAttributesOf (IShellFolder2 * iface, UINT cidl,
        LPCITEMIDLIST rpidl = NULL;

        hr = SHBindToParent(This->pidlRoot, &IID_IShellFolder, (LPVOID*)&psfParent, (LPCITEMIDLIST*)&rpidl);
-        if(SUCCEEDED(hr))
+        if(SUCCEEDED(hr)) {
            SHELL32_GetItemAttributes (psfParent, rpidl, rgfInOut);
+            IShellFolder_Release(psfParent);
+        }
    }
    else {
        while (cidl > 0 && *apidl) {

--- a/dlls/shell32/shfldr_mycomp.c
+++ b/dlls/shell32/shfldr_mycomp.c
@@ -443,8 +443,10 @@ static HRESULT WINAPI ISF_MyComputer_fnGetAttributesOf (IShellFolder2 * iface,
        LPCITEMIDLIST rpidl = NULL;

        hr = SHBindToParent(This->pidlRoot, &IID_IShellFolder, (LPVOID*)&psfParent, (LPCITEMIDLIST*)&rpidl);
-        if(SUCCEEDED(hr))
+        if(SUCCEEDED(hr)) {
            SHELL32_GetItemAttributes (psfParent, rpidl, rgfInOut);
+            IShellFolder_Release(psfParent);
+        }
    } else {
        while (cidl > 0 && *apidl) {
            pdump (*apidl);