msxml3: Don't call qsort if we have no data (Coverity).

5e0251f8 · Alistair Leslie-Hughes · Alexandre Julliard · 2ca895cb · 5e0251f8
Commit 5e0251f8 authored Oct 11, 2023 by Alistair Leslie-Hughes Committed by Alexandre Julliard Oct 27, 2023
Show whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

dispex.c dlls/msxml3/dispex.c +1 -1

No files found.
--- a/dlls/msxml3/dispex.c
+++ b/dlls/msxml3/dispex.c
@@ -294,9 +294,9 @@ static dispex_data_t *preprocess_dispex_data(DispatchEx *This)
        data->funcs = heap_realloc(data->funcs, data->func_cnt * sizeof(func_info_t));
    }

+    if(data->funcs) {
        qsort(data->funcs, data->func_cnt, sizeof(func_info_t), dispid_cmp);

-    if(data->funcs) {
        data->name_table = heap_alloc(data->func_cnt * sizeof(func_info_t*));
        for(i=0; i < data->func_cnt; i++)
            data->name_table[i] = data->funcs+i;