hhctl.ocx: Fix reference count leak in InPlace_OnPosRectChange.

Also compare the result of IOleObject_QueryInterface with S_OK instead of using not operator so it is more clear what the code is doing.

hhctl.ocx: Fix reference count leak in InPlace_OnPosRectChange.
602b58ba · Rob Shearman · Alexandre Julliard · 24c5df3d · 602b58ba
Commit 602b58ba authored Aug 17, 2008 by Rob Shearman Committed by Alexandre Julliard Aug 18, 2008
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

webbrowser.c dlls/hhctrl.ocx/webbrowser.c +5 -1

No files found.
--- a/dlls/hhctrl.ocx/webbrowser.c
+++ b/dlls/hhctrl.ocx/webbrowser.c
@@ -365,8 +365,12 @@ static HRESULT STDMETHODCALLTYPE InPlace_OnPosRectChange(IOleInPlaceSite *iface,
    ICOM_THIS_MULTI(IOleClientSiteImpl, lpvtblOleInPlaceSite, iface);
    IOleInPlaceObject *inplace;

-    if (!IOleObject_QueryInterface(This->pBrowserObject, &IID_IOleInPlaceObject, (void **)&inplace))
+    if (IOleObject_QueryInterface(This->pBrowserObject, &IID_IOleInPlaceObject,
+                                  (void **)&inplace) == S_OK)
+    {
        IOleInPlaceObject_SetObjectRects(inplace, lprcPosRect, lprcPosRect);
+        IOleInPlaceObject_Release(inplace);
+    }

    return S_OK;
 }