ole32: Return IUnknown from GITCF_CreateInstance if requested.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com> Signed-off-by: Huw Davies <huw@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

ole32: Return IUnknown from GITCF_CreateInstance if requested.
6187e8db · Alex Henrie · Alexandre Julliard · ef64f276 · 6187e8db
Commit 6187e8db authored Jul 10, 2018 by Alex Henrie Committed by Alexandre Julliard Jul 10, 2018
Show whitespace changes
Inline Side-by-side

Showing with 8 additions and 6 deletions

git.c dlls/ole32/git.c +8 -6

No files found.
--- a/dlls/ole32/git.c
+++ b/dlls/ole32/git.c
@@ -122,9 +122,14 @@ StdGlobalInterfaceTable_QueryInterface(IGlobalInterfaceTable* iface,
  /* Do we implement that interface? */
  if (IsEqualIID(&IID_IUnknown, riid) ||
      IsEqualIID(&IID_IGlobalInterfaceTable, riid))
+  {
    *ppvObject = iface;
+  }
  else
+  {
+    FIXME("(%s), not supported.\n", debugstr_guid(riid));
    return E_NOINTERFACE;
+  }
  /* Now inc the refcount */
  IGlobalInterfaceTable_AddRef(iface);
@@ -314,13 +319,10 @@ static HRESULT WINAPI
 GITCF_CreateInstance(LPCLASSFACTORY iface, LPUNKNOWN pUnk,
                     REFIID riid, LPVOID *ppv)
 {
-  if (IsEqualIID(riid,&IID_IGlobalInterfaceTable)) {
  IGlobalInterfaceTable *git = get_std_git();
-    return IGlobalInterfaceTable_QueryInterface(git, riid, ppv);
+  HRESULT hr = IGlobalInterfaceTable_QueryInterface(git, riid, ppv);
-  }
+  IGlobalInterfaceTable_Release(git);
+  return hr;
-  FIXME("(%s), not supported.\n",debugstr_guid(riid));
-  return E_NOINTERFACE;
 }
 static HRESULT WINAPI GITCF_LockServer(LPCLASSFACTORY iface, BOOL fLock)