If MsiGetProperty(A/W) is called with a NULL for the value buffer but

a value in the size for the value buffer, then Msi fills in the size of the value into the pointer for size. This is tested and confirmed with native MSI.

If MsiGetProperty(A/W) is called with a NULL for the value buffer but
639048b9 · Aric Stewart · Alexandre Julliard · f58eed36 · 639048b9
Commit 639048b9 authored Jul 11, 2005 by Aric Stewart Committed by Alexandre Julliard Jul 11, 2005
Show whitespace changes
Inline Side-by-side

Showing with 8 additions and 0 deletions

package.c dlls/msi/package.c +8 -0

No files found.
--- a/dlls/msi/package.c
+++ b/dlls/msi/package.c
@@ -893,6 +893,10 @@ UINT WINAPI MsiGetPropertyA(MSIHANDLE hInstall, LPCSTR szName, LPSTR szValueBuf,
    if (NULL != szValueBuf && NULL == pchValueBuf)
        return ERROR_INVALID_PARAMETER;

+    /* This was tested against native msi */
+    if (NULL == szValueBuf && NULL != pchValueBuf)
+        *pchValueBuf = 0;
+
    package = msihandle2msiinfo( hInstall, MSIHANDLETYPE_PACKAGE);
    if (!package)
        return ERROR_INVALID_HANDLE;
@@ -920,6 +924,10 @@ UINT WINAPI MsiGetPropertyW(MSIHANDLE hInstall, LPCWSTR szName,
    if (NULL != szValueBuf && NULL == pchValueBuf)
        return ERROR_INVALID_PARAMETER;

+    /* This was tested against native msi */
+    if (NULL == szValueBuf && NULL != pchValueBuf)
+        *pchValueBuf = 0;
+
    package = msihandle2msiinfo( hInstall, MSIHANDLETYPE_PACKAGE);
    if (!package)
        return ERROR_INVALID_HANDLE;