Commit 64802588 authored by André Hentschel's avatar André Hentschel Committed by Alexandre Julliard

msi/tests: Don't test function directly when reporting GetLastError().

parent cea221ca
...@@ -2103,7 +2103,8 @@ static void test_Installer_RegistryValue(void) ...@@ -2103,7 +2103,8 @@ static void test_Installer_RegistryValue(void)
"RegSetValueExW failed\n"); "RegSetValueExW failed\n");
ok(!RegSetValueExW(hkey,szThree,0,REG_BINARY, (const BYTE *)qw, 4), ok(!RegSetValueExW(hkey,szThree,0,REG_BINARY, (const BYTE *)qw, 4),
"RegSetValueExW failed\n"); "RegSetValueExW failed\n");
ok(SetEnvironmentVariableA("MSITEST", "Four"), "SetEnvironmentVariableA failed %d\n", GetLastError()); bRet = SetEnvironmentVariableA("MSITEST", "Four");
ok(bRet, "SetEnvironmentVariableA failed %d\n", GetLastError());
ok(!RegSetValueExW(hkey,szFour,0,REG_EXPAND_SZ, (const BYTE *)szExpand, sizeof(szExpand)), ok(!RegSetValueExW(hkey,szFour,0,REG_EXPAND_SZ, (const BYTE *)szExpand, sizeof(szExpand)),
"RegSetValueExW failed\n"); "RegSetValueExW failed\n");
ok(!RegSetValueExW(hkey,szFive,0,REG_MULTI_SZ, (const BYTE *)szFive, sizeof(szFive)), ok(!RegSetValueExW(hkey,szFive,0,REG_MULTI_SZ, (const BYTE *)szFive, sizeof(szFive)),
......
...@@ -5546,6 +5546,7 @@ static void process_pending_renames(HKEY hkey) ...@@ -5546,6 +5546,7 @@ static void process_pending_renames(HKEY hkey)
for (src = buf; *src; src = dst + strlen(dst) + 1) for (src = buf; *src; src = dst + strlen(dst) + 1)
{ {
DWORD flags = MOVEFILE_COPY_ALLOWED; DWORD flags = MOVEFILE_COPY_ALLOWED;
BOOL fileret;
dst = src + strlen(src) + 1; dst = src + strlen(src) + 1;
...@@ -5573,10 +5574,14 @@ static void process_pending_renames(HKEY hkey) ...@@ -5573,10 +5574,14 @@ static void process_pending_renames(HKEY hkey)
if (*dst) if (*dst)
{ {
if (dst[0] == '\\' && dst[1] == '?' && dst[2] == '?' && dst[3] == '\\') dst += 4; if (dst[0] == '\\' && dst[1] == '?' && dst[2] == '?' && dst[3] == '\\') dst += 4;
ok(MoveFileExA(src, dst, flags), "Failed to move file %s -> %s (%u)\n", src, dst, GetLastError()); fileret = MoveFileExA(src, dst, flags);
ok(fileret, "Failed to move file %s -> %s (%u)\n", src, dst, GetLastError());
} }
else else
ok(DeleteFileA(src), "Failed to delete file %s (%u)\n", src, GetLastError()); {
fileret = DeleteFileA(src);
ok(fileret, "Failed to delete file %s (%u)\n", src, GetLastError());
}
} }
ok(found, "Expected a 'msitest' entry\n"); ok(found, "Expected a 'msitest' entry\n");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment