Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
678ae0f9
Commit
678ae0f9
authored
Aug 26, 2021
by
Michael Stefaniuc
Committed by
Alexandre Julliard
Aug 26, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
shlwapi/tests: Avoid casts from COM object to interface.
Signed-off-by:
Michael Stefaniuc
<
mstefani@winehq.org
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
431f157c
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
6 deletions
+8
-6
ordinal.c
dlls/shlwapi/tests/ordinal.c
+8
-6
No files found.
dlls/shlwapi/tests/ordinal.c
View file @
678ae0f9
...
...
@@ -1423,7 +1423,7 @@ static HRESULT WINAPI Contain_FindConnectionPoint(
else
{
*
ppCP
=
iface
->
pt
[
0
];
I
Unknown_AddRef
((
IUnknown
*
)
*
ppCP
);
I
ConnectionPoint_AddRef
(
*
ppCP
);
}
return
S_OK
;
...
...
@@ -1459,7 +1459,8 @@ static void test_IConnectionPoint(void)
dispatch
->
IDispatch_iface
.
lpVtbl
=
&
disp_vtbl
;
dispatch
->
refCount
=
1
;
rc
=
pConnectToConnectionPoint
((
IUnknown
*
)
dispatch
,
&
IID_NULL
,
TRUE
,
(
IUnknown
*
)
container
,
&
cookie
,
&
point
);
rc
=
pConnectToConnectionPoint
((
IUnknown
*
)
&
dispatch
->
IDispatch_iface
,
&
IID_NULL
,
TRUE
,
(
IUnknown
*
)
&
container
->
IConnectionPointContainer_iface
,
&
cookie
,
&
point
);
ok
(
rc
==
S_OK
,
"pConnectToConnectionPoint failed with %x
\n
"
,
rc
);
ok
(
point
!=
NULL
,
"returned ConnectionPoint is NULL
\n
"
);
ok
(
cookie
!=
0xffffffff
,
"invalid cookie returned
\n
"
);
...
...
@@ -1475,15 +1476,16 @@ static void test_IConnectionPoint(void)
rc
=
pIConnectionPoint_SimpleInvoke
(
point
,
0xa1
,
&
params
);
ok
(
rc
==
S_OK
,
"pConnectToConnectionPoint failed with %x
\n
"
,
rc
);
rc
=
pConnectToConnectionPoint
(
NULL
,
&
IID_NULL
,
FALSE
,
(
IUnknown
*
)
container
,
&
cookie
,
NULL
);
rc
=
pConnectToConnectionPoint
(
NULL
,
&
IID_NULL
,
FALSE
,
(
IUnknown
*
)
&
container
->
IConnectionPointContainer_iface
,
&
cookie
,
NULL
);
ok
(
rc
==
S_OK
,
"pConnectToConnectionPoint failed with %x
\n
"
,
rc
);
/* MSDN says this should be required but it crashes on XP
IUnknown_Release(point);
*/
ref
=
I
Unknown_Release
((
IUnknown
*
)
container
);
ref
=
I
ConnectionPointContainer_Release
(
&
container
->
IConnectionPointContainer_iface
);
ok
(
ref
==
0
,
"leftover IConnectionPointContainer reference %i
\n
"
,
ref
);
ref
=
I
Unknown_Release
((
IUnknown
*
)
dispatch
);
ref
=
I
Dispatch_Release
(
&
dispatch
->
IDispatch_iface
);
ok
(
ref
==
0
,
"leftover IDispatch reference %i
\n
"
,
ref
);
}
...
...
@@ -1593,7 +1595,7 @@ static void test_SHPropertyBag_ReadLONG(void)
rc
=
pSHPropertyBag_ReadLONG
(
&
pb
->
IPropertyBag_iface
,
szName1
,
&
out
);
ok
(
rc
==
DISP_E_BADVARTYPE
||
broken
(
rc
==
S_OK
)
||
broken
(
rc
==
S_FALSE
),
"incorrect return %x
\n
"
,
rc
);
ok
(
out
==
0xfeedface
||
broken
(
out
==
0xfeedfa00
),
"value should not have changed %x
\n
"
,
out
);
I
Unknown_Release
((
IUnknown
*
)
pb
);
I
PropertyBag_Release
(
&
pb
->
IPropertyBag_iface
);
}
static
void
test_SHSetWindowBits
(
void
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment