pdh: Zero out magic fields with SecureZeroMemory().

gcc tends to optimize away the magic field cleanup, leading to believe the query is still allocated. Signed-off-by: Eric Pouech <epouech@codeweavers.com>

pdh: Zero out magic fields with SecureZeroMemory().
68edddc9 · Eric Pouech · Alexandre Julliard · b3e0271b · 68edddc9
Commit 68edddc9 authored Nov 07, 2023 by Eric Pouech Committed by Alexandre Julliard Nov 07, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

pdh_main.c dlls/pdh/pdh_main.c +4 -2

No files found.
--- a/dlls/pdh/pdh_main.c
+++ b/dlls/pdh/pdh_main.c
@@ -97,7 +97,8 @@ static struct counter *create_counter( void )

 static void destroy_counter( struct counter *counter )
 {
-    counter->magic = 0;
+    /* Ensure compiler doesn't optimize out the assignment with 0. */
+    SecureZeroMemory( &counter->magic, sizeof( counter->magic ) );
    free( counter->path );
    free( counter );
 }
@@ -130,7 +131,8 @@ static struct query *create_query( void )

 static void destroy_query( struct query *query )
 {
-    query->magic = 0;
+    /* Ensure compiler doesn't optimize out the assignment with 0. */
+    SecureZeroMemory( &query->magic, sizeof( query->magic ) );
    free( query );
 }