jscript: Avoid use after free in JSON_parse().

Signed-off-by: Paul Gofman <pgofman@codeweavers.com> Signed-off-by: Jacek Caban <jacek@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

jscript: Avoid use after free in JSON_parse().
6b22f2bd · Paul Gofman · Alexandre Julliard · 9e725a6d · 6b22f2bd
Commit 6b22f2bd authored Aug 06, 2021 by Paul Gofman Committed by Alexandre Julliard Aug 06, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 6 deletions

json.c dlls/jscript/json.c +4 -6

No files found.
--- a/dlls/jscript/json.c
+++ b/dlls/jscript/json.c
@@ -291,16 +291,14 @@ static HRESULT JSON_parse(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags, unsign
    parse_ctx.end = buf + jsstr_length(str);
    parse_ctx.ctx = ctx;
    hres = parse_json_value(&parse_ctx, &ret);
+    if(SUCCEEDED(hres) && skip_spaces(&parse_ctx)) {
+        FIXME("syntax error\n");
+        hres = E_FAIL;
+    }
    jsstr_release(str);
    if(FAILED(hres))
        return hres;

-    if(skip_spaces(&parse_ctx)) {
-        FIXME("syntax error\n");
-        jsval_release(ret);
-        return E_FAIL;
-    }
-
    if(r)
        *r = ret;
    else