msi: ExpandEnvironmentStringsW returns the required size in characters, so…

msi: ExpandEnvironmentStringsW returns the required size in characters, so multiply the required size by sizeof(WCHAR) when allocating the buffer.

msi: ExpandEnvironmentStringsW returns the required size in characters, so…
6b8b82ef · James Hawkins · Alexandre Julliard · 9ac79498 · 6b8b82ef
Commit 6b8b82ef authored Dec 02, 2009 by James Hawkins Committed by Alexandre Julliard Dec 03, 2009
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

automation.c dlls/msi/automation.c +1 -1

No files found.
--- a/dlls/msi/automation.c
+++ b/dlls/msi/automation.c
@@ -1498,7 +1498,7 @@ static void variant_from_registry_value(VARIANT *pVarResult, DWORD dwType, LPBYT
        case REG_EXPAND_SZ:
            if (!(dwNewSize = ExpandEnvironmentStringsW(szString, szNewString, dwNewSize)))
                ERR("ExpandEnvironmentStrings returned error %d\n", GetLastError());
-            else if (!(szNewString = msi_alloc(dwNewSize)))
+            else if (!(szNewString = msi_alloc(dwNewSize * sizeof(WCHAR))))
                ERR("Out of memory\n");
            else if (!(dwNewSize = ExpandEnvironmentStringsW(szString, szNewString, dwNewSize)))
                ERR("ExpandEnvironmentStrings returned error %d\n", GetLastError());