Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
6bfead84
Commit
6bfead84
authored
Sep 12, 2008
by
Rob Shearman
Committed by
Alexandre Julliard
Sep 12, 2008
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
advpack: Add explicit "!= S_OK" to expressions that use HRESULTs as booleans.
parent
19e9b665
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
5 deletions
+5
-5
files.c
dlls/advpack/files.c
+1
-1
install.c
dlls/advpack/install.c
+3
-3
reg.c
dlls/advpack/reg.c
+1
-1
No files found.
dlls/advpack/files.c
View file @
6bfead84
...
...
@@ -627,7 +627,7 @@ static DWORD fill_file_list(SESSION *session, LPCSTR szCabName, LPCSTR szFileLis
struct
FILELIST
*
pNode
;
session
->
Operation
|=
EXTRACT_FILLFILELIST
;
if
(
pExtract
(
session
,
szCabName
))
if
(
pExtract
(
session
,
szCabName
)
!=
S_OK
)
{
session
->
Operation
&=
~
EXTRACT_FILLFILELIST
;
return
-
1
;
...
...
dlls/advpack/install.c
View file @
6bfead84
...
...
@@ -91,7 +91,7 @@ static HRESULT del_dirs_callback(HINF hinf, PCWSTR field, const void *arg)
MAX_INF_STRING_LENGTH
,
&
size
))
continue
;
if
(
DelNodeW
(
directory
,
ADN_DEL_IF_EMPTY
))
if
(
DelNodeW
(
directory
,
ADN_DEL_IF_EMPTY
)
!=
S_OK
)
hr
=
E_FAIL
;
}
...
...
@@ -161,7 +161,7 @@ static HRESULT register_ocxs_callback(HINF hinf, PCWSTR field, const void *arg)
hm
=
LoadLibraryExW
(
buffer
,
NULL
,
LOAD_WITH_ALTERED_SEARCH_PATH
);
if
(
hm
)
{
if
(
do_ocx_reg
(
hm
,
TRUE
))
if
(
do_ocx_reg
(
hm
,
TRUE
)
!=
S_OK
)
hr
=
E_FAIL
;
FreeLibrary
(
hm
);
...
...
@@ -196,7 +196,7 @@ static HRESULT run_setup_commands_callback(HINF hinf, PCWSTR field, const void *
MAX_INF_STRING_LENGTH
,
&
size
))
continue
;
if
(
launch_exe
(
buffer
,
info
->
working_dir
,
NULL
))
if
(
launch_exe
(
buffer
,
info
->
working_dir
,
NULL
)
!=
S_OK
)
hr
=
E_FAIL
;
}
...
...
dlls/advpack/reg.c
View file @
6bfead84
...
...
@@ -230,7 +230,7 @@ HRESULT WINAPI RegInstallW(HMODULE hm, LPCWSTR pszSection, const STRTABLEW* pstT
if
(
!
create_tmp_ini_file
(
hm
,
tmp_ini_path
))
return
E_FAIL
;
if
(
write_predefined_strings
(
hm
,
tmp_ini_path
))
if
(
write_predefined_strings
(
hm
,
tmp_ini_path
)
!=
S_OK
)
goto
done
;
/* Write the additional string table */
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment