wininet: Cut of the query string before searching for the filename in CreateUrlCacheEntryW().

Apparently it's possible to receive URLs with e.g. slashes in the query string. I was under the impression those were reserved in the query string, but e.g. Firefox will happily accept them as well.

wininet: Cut of the query string before searching for the filename in CreateUrlCacheEntryW().
6e46e904 · Henri Verbeet · Alexandre Julliard · 7782e818 · 6e46e904
Commit 6e46e904 authored Sep 23, 2010 by Henri Verbeet Committed by Alexandre Julliard Sep 23, 2010
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 4 deletions

urlcache.c dlls/wininet/urlcache.c +6 -4

No files found.
--- a/dlls/wininet/urlcache.c
+++ b/dlls/wininet/urlcache.c
@@ -2271,6 +2271,12 @@ BOOL WINAPI CreateUrlCacheEntryW(
    if (((lpszUrlEnd - lpszUrlName) > 1) && (*(lpszUrlEnd - 1) == '/' || *(lpszUrlEnd - 1) == '\\'))
        lpszUrlEnd--;

+    lpszUrlPart = memchrW(lpszUrlName, '?', lpszUrlEnd - lpszUrlName);
+    if (!lpszUrlPart)
+        lpszUrlPart = memchrW(lpszUrlName, '#', lpszUrlEnd - lpszUrlName);
+    if (lpszUrlPart)
+        lpszUrlEnd = lpszUrlPart;
+
    for (lpszUrlPart = lpszUrlEnd; 
        (lpszUrlPart >= lpszUrlName); 
        lpszUrlPart--)
@@ -2281,10 +2287,6 @@ BOOL WINAPI CreateUrlCacheEntryW(
            lpszUrlPart++;
            break;
        }
-        else if(*lpszUrlPart == '?' || *lpszUrlPart == '#')
-        {
-            lpszUrlEnd = lpszUrlPart;
-        }
    }
    if (!lstrcmpW(lpszUrlPart, szWWW))
    {