shell32: Do not set the default menu item from ShellView_DoContextMenu().

This was added in f045c9df, with no explanation. It does not affect any behaviour in Wine, since FWF_DESKTOP is never set. It does not make sense, since "open" is already usually the default action on Windows, and it's not obvious why FWF_DESKTOP would affect this. It also leans on IContextMenu implementation details.

shell32: Do not set the default menu item from ShellView_DoContextMenu().
6fd349c6 · Zebediah Figura · Alexandre Julliard · d9c4f506 · 6fd349c6
Commit 6fd349c6 authored Feb 16, 2024 by Zebediah Figura Committed by Alexandre Julliard Feb 19, 2024
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 3 deletions

shlview.c dlls/shell32/shlview.c +0 -3

No files found.
--- a/dlls/shell32/shlview.c
+++ b/dlls/shell32/shlview.c
@@ -1039,9 +1039,6 @@ static void ShellView_DoContextMenu(IShellViewImpl * This, WORD x, WORD y, BOOL 
 	      /* let the ContextMenu merge its items in */
 	      if (SUCCEEDED(IContextMenu_QueryContextMenu( pContextMenu, hMenu, 0, FCIDM_SHVIEWFIRST, FCIDM_SHVIEWLAST, wFlags )))
 	      {
-	        if (This->FolderSettings.fFlags & FWF_DESKTOP)
-		  SetMenuDefaultItem(hMenu, FCIDM_SHVIEW_OPEN, MF_BYCOMMAND);
-
 		if( bDefault )
 		{
 		  TRACE("-- get menu default command\n");