shell32: Don't fall back to $HOME for missing user special folders.

Fall through in create_link and allow SHGetFolderPathAndSubDirW to create an empty folder in place if the alternatives are not available. Creating a link back to $HOME makes a recursive directory structure, which results in crashes in programs that naively search %USERPROFILE% (e.g. Quicken).

shell32: Don't fall back to $HOME for missing user special folders.
710eec8f · Tim Clem · Alexandre Julliard · 788a6122 · 710eec8f
Commit 710eec8f authored Jul 13, 2023 by Tim Clem Committed by Alexandre Julliard Jul 14, 2023
Show whitespace changes
Inline Side-by-side

Showing with 1 addition and 4 deletions

shellpath.c dlls/shell32/shellpath.c +1 -4

No files found.
--- a/dlls/shell32/shellpath.c
+++ b/dlls/shell32/shellpath.c
@@ -2767,10 +2767,7 @@ static void create_link( const WCHAR *path, const char *xdg_name, const char *de
    {
        if (link_folder( mgr, &nt_name, target )) goto done;
    }
-    if (link_folder( mgr, &nt_name, default_name )) goto done;
-
-    /* fall back to HOME */
-    link_folder( mgr, &nt_name, "$HOME" );
+    link_folder( mgr, &nt_name, default_name );

 done:
    RtlFreeUnicodeString( &nt_name );