mshtml: Fixed leak in fill_props.

720c0c81 · Jacek Caban · Alexandre Julliard · 6b0f51f9 · 720c0c81
Commit 720c0c81 authored Nov 21, 2012 by Jacek Caban Committed by Alexandre Julliard Nov 21, 2012
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

propbag.c dlls/mshtml/propbag.c +2 -1

No files found.
--- a/dlls/mshtml/propbag.c
+++ b/dlls/mshtml/propbag.c
@@ -288,7 +288,7 @@ static HRESULT fill_props(nsIDOMHTMLElement *nselem, PropertyBag *prop_bag)

    nsres = nsIDOMNodeList_GetLength(params, &length);
    if(NS_FAILED(nsres))
-        return S_OK;
+        length = 0;

    for(i=0; i < length; i++) {
        nsres = nsIDOMNodeList_Item(params, i, &nsnode);
@@ -330,6 +330,7 @@ static HRESULT fill_props(nsIDOMHTMLElement *nselem, PropertyBag *prop_bag)
        }
    }

+    nsIDOMNodeList_Release(params);
    return hres;
 }