Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
73774b3e
Commit
73774b3e
authored
Jun 11, 2010
by
Hans Leidekker
Committed by
Alexandre Julliard
Jun 11, 2010
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msi: Disable an optimization in the execution of WHERE clauses.
There's no guarantee that the condition strings are in the string table.
parent
15f5b9dc
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
1 deletion
+5
-1
db.c
dlls/msi/tests/db.c
+1
-1
where.c
dlls/msi/where.c
+4
-0
No files found.
dlls/msi/tests/db.c
View file @
73774b3e
...
...
@@ -1933,7 +1933,7 @@ static void test_where(void)
rec
=
0
;
query
=
"SELECT * FROM `Media` WHERE `DiskPrompt` <> 'Cabinet'"
;
r
=
do_query
(
hdb
,
query
,
&
rec
);
todo_wine
ok
(
r
==
ERROR_SUCCESS
,
"query failed: %d
\n
"
,
r
);
ok
(
r
==
ERROR_SUCCESS
,
"query failed: %d
\n
"
,
r
);
MsiCloseHandle
(
rec
);
rec
=
0
;
...
...
dlls/msi/where.c
View file @
73774b3e
...
...
@@ -397,6 +397,9 @@ static UINT WHERE_execute( struct tagMSIVIEW *view, MSIRECORD *record )
return
ERROR_OUTOFMEMORY
;
wv
->
row_count
=
0
;
if
(
0
)
/* disable optimization, there's no guarantee that strings are in the string table */
{
if
(
wv
->
cond
->
type
==
EXPR_STRCMP
)
{
MSIITERHANDLE
handle
=
NULL
;
...
...
@@ -441,6 +444,7 @@ static UINT WHERE_execute( struct tagMSIVIEW *view, MSIRECORD *record )
}
/* else fallback to slow case */
}
}
for
(
i
=
0
;
i
<
count
;
i
++
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment