Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
75606f35
Commit
75606f35
authored
Oct 05, 2008
by
Michael Karcher
Committed by
Alexandre Julliard
Oct 06, 2008
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msxml3: removeChild can only delete direct children.
parent
d1c8083b
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
11 deletions
+5
-11
node.c
dlls/msxml3/node.c
+3
-9
domdoc.c
dlls/msxml3/tests/domdoc.c
+2
-2
No files found.
dlls/msxml3/node.c
View file @
75606f35
...
...
@@ -619,7 +619,7 @@ static HRESULT WINAPI xmlnode_removeChild(
IXMLDOMNode
**
oldChild
)
{
xmlnode
*
This
=
impl_from_IXMLDOMNode
(
iface
);
xmlNode
*
ancestor
,
*
child_node_ptr
;
xmlNode
*
child_node_ptr
;
HRESULT
hr
;
IXMLDOMNode
*
child
;
...
...
@@ -634,14 +634,8 @@ static HRESULT WINAPI xmlnode_removeChild(
if
(
FAILED
(
hr
))
return
hr
;
child_node_ptr
=
ancestor
=
impl_from_IXMLDOMNode
(
child
)
->
node
;
while
(
ancestor
->
parent
)
{
if
(
ancestor
->
parent
==
This
->
node
)
break
;
ancestor
=
ancestor
->
parent
;
}
if
(
!
ancestor
->
parent
)
child_node_ptr
=
impl_from_IXMLDOMNode
(
child
)
->
node
;
if
(
child_node_ptr
->
parent
!=
This
->
node
)
{
WARN
(
"childNode %p is not a child of %p
\n
"
,
childNode
,
iface
);
IXMLDOMNode_Release
(
child
);
...
...
dlls/msxml3/tests/domdoc.c
View file @
75606f35
...
...
@@ -1797,8 +1797,8 @@ static void test_removeChild(void)
/* ba_node is a descendant of element, but not a direct child. */
removed_node
=
(
void
*
)
0xdeadbeef
;
r
=
IXMLDOMElement_removeChild
(
element
,
ba_node
,
&
removed_node
);
todo_wine
ok
(
r
==
E_INVALIDARG
,
"ret %08x
\n
"
,
r
);
todo_wine
ok
(
removed_node
==
NULL
,
"%p
\n
"
,
removed_node
);
ok
(
r
==
E_INVALIDARG
,
"ret %08x
\n
"
,
r
);
ok
(
removed_node
==
NULL
,
"%p
\n
"
,
removed_node
);
r
=
IXMLDOMElement_removeChild
(
element
,
fo_node
,
&
removed_node
);
ok
(
r
==
S_OK
,
"ret %08x
\n
"
,
r
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment