wininet: Check URLCache_LocalFileNameToPathW() return values in CreateUrlCacheEntryW().

It would be unfortunate if a long file name would cause us to open a file based on mostly uninitialized data and write the contents of some random webpage into it.

wininet: Check URLCache_LocalFileNameToPathW() return values in CreateUrlCacheEntryW().
7782e818 · Henri Verbeet · Alexandre Julliard · 578df29b · 7782e818
Commit 7782e818 authored Sep 23, 2010 by Henri Verbeet Committed by Alexandre Julliard Sep 23, 2010
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 1 deletion

urlcache.c dlls/wininet/urlcache.c +7 -1

No files found.
--- a/dlls/wininet/urlcache.c
+++ b/dlls/wininet/urlcache.c
@@ -2330,7 +2330,13 @@ BOOL WINAPI CreateUrlCacheEntryW(
    CacheDir = (BYTE)(rand() % pHeader->DirectoryCount);

    lBufferSize = MAX_PATH * sizeof(WCHAR);
-    URLCache_LocalFileNameToPathW(pContainer, pHeader, szFile, CacheDir, lpszFileName, &lBufferSize);
+    if (!URLCache_LocalFileNameToPathW(pContainer, pHeader, szFile, CacheDir, lpszFileName, &lBufferSize))
+    {
+        WARN("Failed to get full path for filename %s, needed %u bytes.\n",
+                debugstr_a(szFile), lBufferSize);
+        URLCacheContainer_UnlockIndex(pContainer, pHeader);
+        return FALSE;
+    }

    URLCacheContainer_UnlockIndex(pContainer, pHeader);