conhost: Fix memory leak on error path in create_screen_buffer (cppcheck).

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

conhost: Fix memory leak on error path in create_screen_buffer (cppcheck).
78df9cb9 · Alex Henrie · Alexandre Julliard · 36af6828 · 78df9cb9
Commit 78df9cb9 authored Feb 02, 2022 by Alex Henrie Committed by Alexandre Julliard Feb 02, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

conhost.c programs/conhost/conhost.c +5 -1

No files found.
--- a/programs/conhost/conhost.c
+++ b/programs/conhost/conhost.c
@@ -100,7 +100,11 @@ static struct screen_buffer *create_screen_buffer( struct console *console, int 
        if (screen_buffer->font.face_len)
        {
            screen_buffer->font.face_name = malloc( screen_buffer->font.face_len * sizeof(WCHAR) );
-            if (!screen_buffer->font.face_name) return NULL;
+            if (!screen_buffer->font.face_name)
+            {
+                free( screen_buffer );
+                return NULL;
+            }

            memcpy( screen_buffer->font.face_name, console->active->font.face_name,
                    screen_buffer->font.face_len * sizeof(WCHAR) );