Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
791bc1cb
Commit
791bc1cb
authored
Sep 02, 2012
by
Marcus Meissner
Committed by
Alexandre Julliard
Sep 03, 2012
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
quartz: Handle freeing pins in error case (Coverity).
parent
c7355f79
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
3 deletions
+5
-3
filtergraph.c
dlls/quartz/filtergraph.c
+5
-3
No files found.
dlls/quartz/filtergraph.c
View file @
791bc1cb
...
...
@@ -906,12 +906,13 @@ static HRESULT WINAPI FilterGraph2_Connect(IFilterGraph2 *iface, IPin *ppinOut,
IEnumPins
*
penumpins
;
IEnumMoniker
*
pEnumMoniker
;
GUID
tab
[
2
];
ULONG
nb
;
ULONG
nb
=
0
;
IMoniker
*
pMoniker
;
ULONG
pin
;
PIN_INFO
PinInfo
;
CLSID
FilterCLSID
;
PIN_DIRECTION
dir
;
unsigned
int
i
=
0
;
TRACE
(
"(%p/%p)->(%p, %p)
\n
"
,
This
,
iface
,
ppinOut
,
ppinIn
);
...
...
@@ -1012,7 +1013,7 @@ static HRESULT WINAPI FilterGraph2_Connect(IFilterGraph2 *iface, IPin *ppinOut,
{
VARIANT
var
;
GUID
clsid
;
IPin
**
ppins
;
IPin
**
ppins
=
NULL
;
IPin
*
ppinfilter
=
NULL
;
IBaseFilter
*
pfilter
=
NULL
;
IAMGraphBuilderCallback
*
callback
=
NULL
;
...
...
@@ -1104,7 +1105,6 @@ static HRESULT WINAPI FilterGraph2_Connect(IFilterGraph2 *iface, IPin *ppinOut,
hr
=
GetInternalConnections
(
pfilter
,
ppinfilter
,
&
ppins
,
&
nb
);
if
(
SUCCEEDED
(
hr
))
{
unsigned
int
i
;
if
(
nb
==
0
)
{
IPin_Disconnect
(
ppinfilter
);
IPin_Disconnect
(
ppinOut
);
...
...
@@ -1157,6 +1157,8 @@ error:
IFilterGraph2_RemoveFilter
(
iface
,
pfilter
);
IBaseFilter_Release
(
pfilter
);
}
while
(
++
i
<
nb
)
IPin_Release
(
ppins
[
i
]);
CoTaskMemFree
(
ppins
);
}
out:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment