Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
7a4b59b0
Commit
7a4b59b0
authored
Feb 13, 2006
by
H. Verbeet
Committed by
Alexandre Julliard
Feb 13, 2006
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
wined3d: Don't keep a reference to the container, as it creates a
circular reference.
parent
0ff18f58
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
18 deletions
+2
-18
surface.c
dlls/wined3d/surface.c
+1
-9
volume.c
dlls/wined3d/volume.c
+1
-9
No files found.
dlls/wined3d/surface.c
View file @
7a4b59b0
...
...
@@ -69,9 +69,6 @@ ULONG WINAPI IWineD3DSurfaceImpl_Release(IWineD3DSurface *iface) {
glDeleteTextures
(
1
,
&
This
->
glDescription
.
textureName
);
LEAVE_GL
();
}
if
(
This
->
container
)
{
IWineD3DBase_Release
(
This
->
container
);
}
IWineD3DResourceImpl_CleanUp
((
IWineD3DResource
*
)
iface
);
TRACE
(
"(%p) Released
\n
"
,
This
);
...
...
@@ -1357,12 +1354,7 @@ HRESULT WINAPI IWineD3DSurfaceImpl_SetContainer(IWineD3DSurface *iface, IWineD3D
TRACE
(
"This %p, container %p
\n
"
,
This
,
container
);
if
(
container
)
{
IWineD3DBase_AddRef
(
container
);
}
if
(
This
->
container
)
{
IWineD3DBase_Release
(
This
->
container
);
}
/* We can't keep a reference to the container, since the container already keeps a reference to us. */
TRACE
(
"Setting container to %p from %p
\n
"
,
container
,
This
->
container
);
This
->
container
=
container
;
...
...
dlls/wined3d/volume.c
View file @
7a4b59b0
...
...
@@ -55,9 +55,6 @@ ULONG WINAPI IWineD3DVolumeImpl_Release(IWineD3DVolume *iface) {
TRACE
(
"(%p) : Releasing from %ld
\n
"
,
This
,
This
->
resource
.
ref
);
ref
=
InterlockedDecrement
(
&
This
->
resource
.
ref
);
if
(
ref
==
0
)
{
if
(
This
->
container
)
{
IWineD3DBase_Release
(
This
->
container
);
}
IWineD3DResourceImpl_CleanUp
((
IWineD3DResource
*
)
iface
);
HeapFree
(
GetProcessHeap
(),
0
,
This
);
}
...
...
@@ -252,12 +249,7 @@ HRESULT WINAPI IWineD3DVolumeImpl_SetContainer(IWineD3DVolume *iface, IWineD3DBa
TRACE
(
"This %p, container %p
\n
"
,
This
,
container
);
if
(
container
)
{
IWineD3DBase_AddRef
(
container
);
}
if
(
This
->
container
)
{
IWineD3DBase_Release
(
This
->
container
);
}
/* We can't keep a reference to the container, since the container already keeps a reference to us. */
TRACE
(
"Setting container to %p from %p
\n
"
,
container
,
This
->
container
);
This
->
container
=
container
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment