Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
86609976
Commit
86609976
authored
Aug 22, 2010
by
Henri Verbeet
Committed by
Alexandre Julliard
Aug 23, 2010
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
ddraw: Attaching an already attached surface is not a FIXME.
According to the tests it should simply fail.
parent
3fd66bc6
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
6 deletions
+7
-6
surface.c
dlls/ddraw/surface.c
+7
-6
No files found.
dlls/ddraw/surface.c
View file @
86609976
...
...
@@ -988,13 +988,14 @@ static HRESULT WINAPI ddraw_surface_attach_surface(IDirectDrawSurfaceImpl *This,
EnterCriticalSection
(
&
ddraw_cs
);
/* Check if the surface is already attached somewhere */
if
(
(
Surf
->
next_attached
!=
NULL
)
||
(
Surf
->
first_attached
!=
Surf
)
)
if
(
Surf
->
next_attached
||
Surf
->
first_attached
!=
Surf
)
{
/* TODO: Test for the structure of the manual attachment. Is it a chain or a list?
* What happens if one surface is attached to 2 different surfaces?
*/
FIXME
(
"(%p) The Surface %p is already attached somewhere else: next_attached = %p, first_attached = %p, can't handle by now
\n
"
,
This
,
Surf
,
Surf
->
next_attached
,
Surf
->
first_attached
);
/* TODO: Test for the structure of the manual attachment. Is it a
* chain or a list? What happens if one surface is attached to 2
* different surfaces? */
WARN
(
"Surface %p is already attached somewhere. next_attached %p, first_attached %p.
\n
"
,
Surf
,
Surf
->
next_attached
,
Surf
->
first_attached
);
LeaveCriticalSection
(
&
ddraw_cs
);
return
DDERR_SURFACEALREADYATTACHED
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment