mshtml: Fix some IUri leaks (Valgrind).

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Jacek Caban <jacek@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

mshtml: Fix some IUri leaks (Valgrind).
892d2e8c · Nikolay Sivov · Alexandre Julliard · 15a07c07 · 892d2e8c
Commit 892d2e8c authored Nov 10, 2016 by Nikolay Sivov Committed by Alexandre Julliard Nov 14, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

script.c dlls/mshtml/script.c +5 -1

No files found.
--- a/dlls/mshtml/script.c
+++ b/dlls/mshtml/script.c
@@ -1056,12 +1056,15 @@ HRESULT load_script(HTMLScriptElement *script_elem, const WCHAR *src, BOOL async
        return hres;

    hres = CreateURLMonikerEx2(NULL, uri, &mon, URL_MK_UNIFORM);
-    if(FAILED(hres))
+    if(FAILED(hres)) {
+        IUri_Release(uri);
        return hres;
+    }

    bsc = heap_alloc_zero(sizeof(*bsc));
    if(!bsc) {
        IMoniker_Release(mon);
+        IUri_Release(uri);
        return E_OUTOFMEMORY;
    }

@@ -1069,6 +1072,7 @@ HRESULT load_script(HTMLScriptElement *script_elem, const WCHAR *src, BOOL async
    IMoniker_Release(mon);

    hres = IUri_GetScheme(uri, &bsc->scheme);
+    IUri_Release(uri);
    if(FAILED(hres))
        bsc->scheme = URL_SCHEME_UNKNOWN;