crypt32: Handle NULL ptr leak in CryptDecodeObjectEx (Coverity).

896be411 · Marcus Meissner · Alexandre Julliard · 80d12c35 · 896be411
Commit 896be411 authored Dec 31, 2010 by Marcus Meissner Committed by Alexandre Julliard Jan 03, 2011
Show whitespace changes
Inline Side-by-side

Showing with 8 additions and 1 deletion

decode.c dlls/crypt32/decode.c +8 -1

No files found.
--- a/dlls/crypt32/decode.c
+++ b/dlls/crypt32/decode.c
@@ -5976,8 +5976,15 @@ BOOL WINAPI CryptDecodeObjectEx(DWORD dwCertEncodingType, LPCSTR lpszStructType,
    }

    SetLastError(NOERROR);
-    if (dwFlags & CRYPT_DECODE_ALLOC_FLAG && pvStructInfo)
+    if (dwFlags & CRYPT_DECODE_ALLOC_FLAG)
+    {
+        if (!pvStructInfo)
+        {
+            SetLastError(ERROR_INVALID_PARAMETER);
+            return FALSE;
+        }
        *(BYTE **)pvStructInfo = NULL;
+    }
    decodeFunc = CRYPT_GetBuiltinDecoder(dwCertEncodingType, lpszStructType);
    if (!decodeFunc)
    {